Close constructed sessions when server negotiation fails - #13
Open
OskarEichler wants to merge 1 commit into
Open
Close constructed sessions when server negotiation fails#13OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close constructed server sessions if a later factory, response generation or serialization step fails before ownership is installed on the container.
Reproduction and verification
Three focused checks cover failure in a later response/factory and successful sessions remaining open until normal close. Existing server negotiation examples pass.
Breaking changes and limitations
No intended breaking change for successful negotiation. Failed handshakes now release constructed sessions; original error behavior is preserved for normal StandardError cleanup callbacks.
Only local Ruby 4.0.6/macOS execution is claimed; the repository's older Ruby/JRuby matrix needs upstream CI. No production access or unrelated release upgrades.