Reject repeated activation of the same extension session - #11
Open
OskarEichler wants to merge 1 commit into
Open
Reject repeated activation of the same extension session#11OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject repeated server responses for the same client extension, including extensions that use no reserved bits. A single session must not be activated or inserted into the message-processing stack twice.
Reproduction and verification
Focused duplicate-response reproduction passes; existing reserved-bit conflict and negotiation-order examples remain green. The framework documents one response parameter set per extension and creates one client session per name.
Breaking changes and limitations
Intentional behavior correction: duplicate activation previously slipped through for zero-RSV extensions and ran the same transformer twice. It now raises ExtensionError.
Only local Ruby 4.0.6/macOS execution is claimed; the repository's older Ruby/JRuby matrix needs upstream CI. No production access or unrelated release upgrades.