fix: use named import for connect-redis v8.x#343
Merged
Conversation
b2c478c to
164e484
Compare
is2ei
reviewed
Jul 13, 2026
164e484 to
3363308
Compare
is2ei
reviewed
Jul 13, 2026
is2ei
reviewed
Jul 13, 2026
75c3cfb to
bf571cb
Compare
bf571cb to
9a8c488
Compare
9a8c488 to
13f87c1
Compare
is2ei
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
connect-redisto^8.0.0and updates the imports that broke because of it ( see v8.0.0 here: https://github.com/tj/connect-redis/releases/tag/v9.0.0)Changes:
Since v8 ( see v8.0.0 here: https://github.com/tj/connect-redis/releases/tag/v8.0.0),
connect-redisno longer has a default exportRedisStoreis now a named export only. This broke:types/index.tst.ts— type-check failure (tstyche, TS2351: "This expression is not constructable")examples/redis.jsandbenchmark/bench.js— runtime error, sincerequire('connect-redis').defaultresolves toundefined