Logo (Builtin): update OpenWrt logo#2376
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The PR updates the OpenWrt ASCII logo and introduces a 'small' variant, which aligns with official branding. While Codacy analysis indicates the code is up to standards, the review identified a critical preprocessor guard mismatch in src/logo/ascii/o.inc that may cause build failures if logos are selectively excluded. Additionally, there is a gap in the logo discovery logic that prevents the small variant from being easily accessed via standard CLI flags. Addressing these issues is necessary to ensure build stability and expected functionality.
About this PR
- The PR lacks automated unit or integration tests to verify the rendering of the new logo variants. Future changes to ASCII processing or color mapping might break these designs without immediate detection.
Test suggestions
- Verify that the 'openwrt' large logo renders correctly with the defined two-color palette (White/Blue).
- Verify that the 'openwrt_small' logo renders correctly with the defined two-color palette (White/Blue).
- Verify that the build system correctly identifies and includes the new 'openwrt_small.txt' data macro.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the 'openwrt' large logo renders correctly with the defined two-color palette (White/Blue).
2. Verify that the 'openwrt_small' logo renders correctly with the defined two-color palette (White/Blue).
3. Verify that the build system correctly identifies and includes the new 'openwrt_small.txt' data macro.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
Let's keep the old logo as |
0dc902f to
9bfe037
Compare
9bfe037 to
3b17588
Compare
Update the large logo for OpenWrt based on the official branding. Add a small logo version. Keep the old logo as openwrt_old.txt Signed-off-by: Valeriy Kosikhin <vkosikhin@gmail.com>
3b17588 to
f5caa40
Compare
|
Thanks. I'm about to cut a hotfix release, so v2.64.2 will have this one |
Update the large logo for OpenWrt based on the official branding. Add a small logo version.
Changes
Screenshots
Checklist