Skip to content

Logo (Builtin): update OpenWrt logo#2376

Merged
CarterLi merged 1 commit into
fastfetch-cli:devfrom
betonmischer86:openwrt-logo
Jun 5, 2026
Merged

Logo (Builtin): update OpenWrt logo#2376
CarterLi merged 1 commit into
fastfetch-cli:devfrom
betonmischer86:openwrt-logo

Conversation

@betonmischer86
Copy link
Copy Markdown
Contributor

Update the large logo for OpenWrt based on the official branding. Add a small logo version.

Changes

  • Replace the existing OpenWrt logo with an updated two-color design matching the official branding.
  • Add a small logo variant.

Screenshots

openwrt

Checklist

  • I have tested my changes locally.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Jun 5, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown

@codacy-production codacy-production Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR updates the OpenWrt ASCII logo and introduces a 'small' variant, which aligns with official branding. While Codacy analysis indicates the code is up to standards, the review identified a critical preprocessor guard mismatch in src/logo/ascii/o.inc that may cause build failures if logos are selectively excluded. Additionally, there is a gap in the logo discovery logic that prevents the small variant from being easily accessed via standard CLI flags. Addressing these issues is necessary to ensure build stability and expected functionality.

About this PR

  • The PR lacks automated unit or integration tests to verify the rendering of the new logo variants. Future changes to ASCII processing or color mapping might break these designs without immediate detection.

Test suggestions

  • Verify that the 'openwrt' large logo renders correctly with the defined two-color palette (White/Blue).
  • Verify that the 'openwrt_small' logo renders correctly with the defined two-color palette (White/Blue).
  • Verify that the build system correctly identifies and includes the new 'openwrt_small.txt' data macro.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the 'openwrt' large logo renders correctly with the defined two-color palette (White/Blue).
2. Verify that the 'openwrt_small' logo renders correctly with the defined two-color palette (White/Blue).
3. Verify that the build system correctly identifies and includes the new 'openwrt_small.txt' data macro.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread src/logo/ascii/o.inc Outdated
@CarterLi
Copy link
Copy Markdown
Member

CarterLi commented Jun 5, 2026

Let's keep the old logo as openwrt2 in case someone like it.

Comment thread src/logo/ascii/o.inc Outdated
Comment thread src/logo/ascii/o.inc Outdated
Comment thread src/logo/ascii/o.inc Outdated
Update the large logo for OpenWrt based on the official branding.
Add a small logo version.
Keep the old logo as openwrt_old.txt

Signed-off-by: Valeriy Kosikhin <vkosikhin@gmail.com>
@CarterLi CarterLi merged commit da568c9 into fastfetch-cli:dev Jun 5, 2026
1 check passed
@CarterLi
Copy link
Copy Markdown
Member

CarterLi commented Jun 5, 2026

Thanks.

I'm about to cut a hotfix release, so v2.64.2 will have this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants