Release v2.64.2 by CarterLi · Pull Request #2375 · fastfetch-cli/fastfetch

CarterLi · 2026-06-05T06:54:00Z

Checklist

I have tested my changes locally.

Regression from v2.64.0 Fixes: #2374

…rval` mode

codacy-production · 2026-06-05T06:54:22Z

Not up to standards ⛔

🔴 Issues 1 critical

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results

Security 1 critical

View in Codacy

🟢 Metrics 0 complexity

Metric Results

Complexity 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

codacy-production

Pull Request Overview

While this PR successfully addresses image logo persistence regressions from v2.64.0, it introduces significant logic errors that affect right-aligned logos and ASCII logos taller than the output data when running in --dynamic-interval mode.

Specifically, the logic intended to fix logo overwriting now causes right-aligned logos to be incorrectly shifted and results in the bottom portion of tall ASCII logos being wiped during screen clears. Although the Codacy analysis is 'up to standards', these functional regressions should be addressed to fully satisfy the requirement of fixing logo rendering in dynamic modes.

About this PR

The PR description is minimal and relies entirely on the CHANGELOG.md and commit history for context and implementation details. Providing a high-level summary of the architectural changes for the logo rendering logic would improve reviewability.

Test suggestions

Execute fastfetch with --dynamic-interval and verify the logo is not overwritten by subsequent data updates.
Verify image logo persistence in supported terminals (e.g., Kitty, iTerm2) during dynamic updates.
Verify right-aligned logo positioning remains consistent across refreshes.
Check that the screen is properly cleared (no artifacts) when fetch output size changes between dynamic intervals.

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Execute fastfetch with --dynamic-interval and verify the logo is not overwritten by subsequent data updates.
2. Verify image logo persistence in supported terminals (e.g., Kitty, iTerm2) during dynamic updates.
3. Verify right-aligned logo positioning remains consistent across refreshes.
4. Check that the screen is properly cleared (no artifacts) when fetch output size changes between dynamic intervals.

_{TIP Improve review quality by adding custom instructions}
_{TIP How was this review? Give us feedback}

codacy-production · 2026-06-05T06:56:06Z

+            ffLogoPrintRemaining(); // `logoLineCacheClear` inside so that ffLogoPrintLine will use `\e[nC` to move the cursor to the right position instead of reprinting the logo
+            fputs("\e[J", stdout); // Clear from cursor to the end of the screen to prevent artifacts when the new output is shorter than the previous one


_{🟡 MEDIUM RISK}

On subsequent iterations of the dynamic interval loop, ffLogoPrintRemaining() returns early because the cache is empty. This leaves the cursor at the end of the data lines. The following \e[J then clears the remainder of the screen, effectively wiping out any part of the ASCII logo that is taller than the data output. To fix this, you should ensure the cursor moves to max(logoHeight, keysHeight) before clearing.

codacy-production · 2026-06-05T06:56:06Z

+    } else if (instance.state.logoWidth > 0) {
+        printf("\033[%uC", instance.state.logoWidth);
    }


_{🟡 MEDIUM RISK}

This unconditional cursor shift incorrectly affects right-aligned logos. When instance.config.logo.position == FF_LOGO_POSITION_RIGHT, the cursor should not be shifted to the right before printing keys, as they should start from the first column. Currently, this logic will cause keys to overlap the logo or create unwanted whitespace on the left.

Copilot

Pull request overview

Release prep for v2.64.2, updating version metadata and documenting/implementing fixes related to logo rendering in --dynamic-interval mode.

Changes:

Adjust logo line-printing/cursor movement behavior to avoid overwriting and improve compatibility with pipeline colorizers.
Update dynamic refresh loop to clear trailing screen content between refreshes.
Bump project version and add 2.64.2 changelog entry.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`src/logo/logo.c`	Updates logo line cache printing/cursor movement logic and some preprocessor formatting.
`src/fastfetch.c`	Tweaks `--dynamic-interval` refresh loop (print remaining logo, clear to end-of-screen, reposition cursor).
`CMakeLists.txt`	Bumps project version to `2.64.2`.
`CHANGELOG.md`	Adds release notes for `2.64.2`.

Update the large logo for OpenWrt based on the official branding. Add a small logo version. Keep the old logo as openwrt_old.txt Signed-off-by: Valeriy Kosikhin <vkosikhin@gmail.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

CarterLi added 3 commits June 5, 2026 13:12

Logo (Image): fixes image renders but quickly gets wiped

ba39687

Regression from v2.64.0 Fixes: #2374

Global: prevents ascii logo from being overwritten in `--dynamic-inte…

6b9f594

…rval` mode

Release: v2.64.2

53c2d07

Copilot AI review requested due to automatic review settings June 5, 2026 06:54

Copilot started reviewing on behalf of CarterLi June 5, 2026 06:54 View session

codacy-production Bot reviewed Jun 5, 2026

View reviewed changes

Copilot AI reviewed Jun 5, 2026

View reviewed changes

Comment thread src/fastfetch.c

Comment thread src/logo/logo.c

Comment thread CHANGELOG.md

CarterLi and others added 4 commits June 5, 2026 15:27

Global: don't clear line in --logo-position right

e79aaf5

Global: resets keysHeight after every refresh

20aabdf

Doc: updates changelog

727fbc0

Logo (Builtin): update OpenWrt logo

da568c9

Update the large logo for OpenWrt based on the official branding. Add a small logo version. Keep the old logo as openwrt_old.txt Signed-off-by: Valeriy Kosikhin <vkosikhin@gmail.com>

Copilot AI review requested due to automatic review settings June 5, 2026 08:15

Copilot started reviewing on behalf of CarterLi June 5, 2026 08:16 View session

Doc: updates changelog [ci skip]

a139a8c

Copilot AI reviewed Jun 5, 2026

View reviewed changes

Comment thread src/logo/ascii/o.inc

Comment thread CHANGELOG.md Outdated

CarterLi and others added 4 commits June 5, 2026 16:34

Logo: addresses review comments of AI

9fe7d6d

Common (Lua): supports BINARY_LINK_TYPE=dynamic

70e6717

Common (QJS): supports BINARY_LINK_TYPE=dynamic

4d3b6c3

Codec (Linux): supports BINARY_LINK_TYPE=dynamic

fc7a0a8

Copilot AI review requested due to automatic review settings June 5, 2026 10:07

Copilot started reviewing on behalf of CarterLi June 5, 2026 10:07 View session

Copilot AI reviewed Jun 5, 2026

View reviewed changes

Comment thread src/common/lua.h

Common (Lua): addresses AI's feedback

cbc84fd

CarterLi merged commit 636471c into master Jun 5, 2026
24 of 47 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release v2.64.2#2375

Release v2.64.2#2375
CarterLi merged 13 commits into
masterfrom
dev

CarterLi commented Jun 5, 2026

Uh oh!

codacy-production Bot commented Jun 5, 2026 •

edited

Loading

Uh oh!

codacy-production Bot left a comment

Uh oh!

codacy-production Bot Jun 5, 2026

Uh oh!

codacy-production Bot Jun 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		ffLogoPrintRemaining(); // `logoLineCacheClear` inside so that ffLogoPrintLine will use `\e[nC` to move the cursor to the right position instead of reprinting the logo
		fputs("\e[J", stdout); // Clear from cursor to the end of the screen to prevent artifacts when the new output is shorter than the previous one

Uh oh!

Conversation

CarterLi commented Jun 5, 2026

Checklist

Uh oh!

codacy-production Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Not up to standards ⛔

Uh oh!

codacy-production Bot left a comment

Choose a reason for hiding this comment

Pull Request Overview

About this PR

Test suggestions

Uh oh!

codacy-production Bot Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

codacy-production Bot Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codacy-production Bot commented Jun 5, 2026 •

edited

Loading