Logo (Builtin): add QuasarLinux#2371
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new ASCII logo variant for QuasarLinux and wires it into the Q logo registry so it can be selected at build time.
Changes:
- Added
src/logo/ascii/q/quasarlinux.txtcontaining the QuasarLinux ASCII art with$1/$2color tokens. - Registered the QuasarLinux logo under
FASTFETCH_DATATEXT_LOGO_QUASARLINUXinsrc/logo/ascii/q.incwith white/blue color mapping.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/logo/ascii/q/quasarlinux.txt | Introduces the QuasarLinux ASCII art and embedded color placeholders. |
| src/logo/ascii/q.inc | Adds a compile-time selectable entry for the new QuasarLinux logo and its colors. |
| /_―'⎺ $2|$1 ⎺'―_\ | ||
| $2| |
| $1 φ | ||
| | | ||
| _⏊_ |
| / _$2|$1_ \ | ||
| / / $2|$1 \ /_ | ||
| / _\ $2|$1 /_ \ | ||
| /_―'⎺ $2|$1 ⎺'―_\ |
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
The pull request successfully introduces the Quasar Linux logo; however, there is a visual inconsistency in the ASCII template that should be addressed to ensure a cohesive appearance.
Automated analysis indicates the code is up to standards, but improvements are recommended for the logo registration to ensure robust detection across different system environments and case sensitivities. The most critical issue is the color mismatch in the central vertical pillar of the ASCII art.
Test suggestions
- Verify the Quasar Linux ASCII logo definition is included in q.inc
- Ensure the ASCII template uses correct color placeholders ($1, $2) matching the defined color array
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| $1 φ | ||
| | | ||
| _⏊_ |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The central vertical axis (the phi in line 1, the bar in line 2, and the tack symbol in line 3) is currently white ($1). It should likely be blue ($2) to remain consistent with the rest of the pillar starting at line 4.
Try running the following prompt in your coding agent:
In src/logo/ascii/q/quasarlinux.txt, update lines 1, 2, and 3 to apply the $2 color code to the central vertical characters (φ, |, ⏊) so they match the color of the pillar in the lines below.
| #ifdef FASTFETCH_DATATEXT_LOGO_QUASARLINUX | ||
| // QuasarLinux | ||
| { | ||
| .names = { "QuasarLinux" }, |
There was a problem hiding this comment.
⚪ LOW RISK
Suggestion: The logo detection and manual selection will be more robust if common name variations are included.
| .names = { "QuasarLinux" }, | |
| .names = { "QuasarLinux", "quasarlinux", "Quasar Linux" }, |
|
Fixed the color leak on the last line. The Unicode characters (φ, ⏊, ―, ⎺) are from the original logo design provided in #2323, keeping as-is. The white ($1) is the primary color for the central pillar per the issue request. Single .names entry to match existing pattern (Quirinux, Quasar, etc). |
Add ASCII logo for Quasar Linux (closes #2323)