feat: add initial support for explicitly driven timers - #137
Draft
orthur2 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial implementation for #118, developed with Codex.
As @tisonkun proposed, timer-related primitives are a natural next step now that most common primitives in
meaare in place. The timer side starts with a reactor-oriented design instead of a standalone runtime-agnostic abstraction, since a timing wheel and driver effectively form a timer reactor. In this direction,delay_untilis the runtime-dependent primitive, while delays, timeouts, intervals, and scheduled actions can be composed on top of it. Timer capability is passed explicitly throughTimerContextinstead of relying on a Tokio-style current handle.Summary
TimerDriverand cloneableTimerContext, with bounded turns and replaceable reactor wake registrationDelayfutures and report driver closure separately from deadline expirationtimeoutandtimeout_at, intervals withBurst,Delay, andSkipbehavior, and three non-spawning scheduling helpersVerification
cargo +1.85.0 test --workspace --no-default-featurescargo +stable test --workspace --no-default-featurescargo x lint@tisonkun, could you take an initial look at the timer/reactor boundary? Since
meadoes not have a reactor yet, this PR exposesTimerDriver,TurnBudget, andTurnResult, and keepsTimerContextstandalone so the timer can be driven explicitly for now. I would especially like your opinion on whether this is a reasonable first shape before reactor integration.Closes #118.