Skip to content

fix(ci): run cargo build/test inline instead of a missing action command - #334

Merged
jdfalk merged 1 commit into
mainfrom
fix/rust-build-inline
Jul 21, 2026
Merged

fix(ci): run cargo build/test inline instead of a missing action command#334
jdfalk merged 1 commit into
mainfrom
fix/rust-build-inline

Conversation

@jdfalk

@jdfalk jdfalk commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

The Rust job in reusable-ci.yml invokes gha-ci-workflow-helpers with
command: rust-build and command: rust-test — but that action never
implemented either command
. Only rust-format and rust-clippy exist, in
every release through v1.1.7. So every repository whose Rust CI actually runs
dies at the build step:

##[error]Unknown command: rust-build

reusable-ci.yml was migrated to call action commands that were never added to
the action. This is fleet-wide — any repo with active Rust CI hits it.

Change

Build Rust project and Test Rust project now run cargo build --release /
cargo test --release inline. Format and Lint keep using the action, which
does support rust-format / rust-clippy.

Kept minimal deliberately — no --locked (would fail any repo with a drifted
lock) and no --all-targets (would force-build benches that some repos gate on
nightly).

Context

Surfaced by falkcorp/cockroach-rollout-agent, whose Rust CI activated for the
first time during the TODO fan-out (its Cargo.lock changed, and Rust CI was
skipped on its main before). Verified the crate itself is clean:
cargo clippy --all-targets -- -D warnings, cargo build --release, and
cargo test all pass locally — the failure was purely this missing-command bug.

Note this is distinct from #333 (the stale ghcommon-script pin): these Rust
commands run through the external action, not the checked-out scripts, so the
pin refresh didn't touch them.

actionlint clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2

…command

The Rust job called gha-ci-workflow-helpers with command: rust-build and
command: rust-test, but the action never implemented those - only
rust-format and rust-clippy exist, across every release through v1.1.7.
Every repo whose Rust CI actually ran therefore died at the build step:

    ##[error]Unknown command: rust-build

reusable-ci was migrated to call action commands that were never added.
Build and test now run `cargo build --release` / `cargo test --release`
inline; format and clippy keep using the action, which supports them.

Surfaced by falkcorp/cockroach-rollout-agent, whose Rust CI activated for
the first time during the TODO fan-out (its Cargo.lock changed). The
crate itself builds, clippies, and tests clean locally - the failure was
purely this missing-command bug.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
@github-actions github-actions Bot added size/S github-actions GitHub Actions related work type:documentation Improvements or additions to documentation module:config Configuration management workflow:github-actions GitHub Actions workflows and removed size/S labels Jul 21, 2026
@jdfalk
jdfalk merged commit 143b2d4 into main Jul 21, 2026
38 of 40 checks passed
@jdfalk
jdfalk deleted the fix/rust-build-inline branch July 21, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github-actions GitHub Actions related work module:config Configuration management type:documentation Improvements or additions to documentation workflow:github-actions GitHub Actions workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant