fix(ci): run cargo build/test inline instead of a missing action command - #334
Merged
Conversation
…command
The Rust job called gha-ci-workflow-helpers with command: rust-build and
command: rust-test, but the action never implemented those - only
rust-format and rust-clippy exist, across every release through v1.1.7.
Every repo whose Rust CI actually ran therefore died at the build step:
##[error]Unknown command: rust-build
reusable-ci was migrated to call action commands that were never added.
Build and test now run `cargo build --release` / `cargo test --release`
inline; format and clippy keep using the action, which supports them.
Surfaced by falkcorp/cockroach-rollout-agent, whose Rust CI activated for
the first time during the TODO fan-out (its Cargo.lock changed). The
crate itself builds, clippies, and tests clean locally - the failure was
purely this missing-command bug.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Rust job in
reusable-ci.ymlinvokesgha-ci-workflow-helperswithcommand: rust-buildandcommand: rust-test— but that action neverimplemented either command. Only
rust-formatandrust-clippyexist, inevery release through v1.1.7. So every repository whose Rust CI actually runs
dies at the build step:
reusable-ci.ymlwas migrated to call action commands that were never added tothe action. This is fleet-wide — any repo with active Rust CI hits it.
Change
Build Rust projectandTest Rust projectnow runcargo build --release/cargo test --releaseinline.FormatandLintkeep using the action, whichdoes support
rust-format/rust-clippy.Kept minimal deliberately — no
--locked(would fail any repo with a driftedlock) and no
--all-targets(would force-build benches that some repos gate onnightly).
Context
Surfaced by
falkcorp/cockroach-rollout-agent, whose Rust CI activated for thefirst time during the TODO fan-out (its
Cargo.lockchanged, and Rust CI wasskippedon its main before). Verified the crate itself is clean:cargo clippy --all-targets -- -D warnings,cargo build --release, andcargo testall pass locally — the failure was purely this missing-command bug.Note this is distinct from #333 (the stale ghcommon-script pin): these Rust
commands run through the external action, not the checked-out scripts, so the
pin refresh didn't touch them.
actionlintclean.🤖 Generated with Claude Code
https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2