fix f-str check #4010 - #4051
Draft
asukaminato0721 wants to merge 1 commit into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
asukaminato0721
marked this pull request as draft
July 5, 2026 14:58
asukaminato0721
force-pushed
the
4010-f-string
branch
from
August 2, 2026 13:35
e589373 to
22622c1
Compare
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D114526430. (Because this pull request was imported automatically, there will not be any future comments.) |
|
Diff from mypy_primer, showing the effect of this PR on open source code: dulwich (https://github.com/dulwich/dulwich)
+ ERROR dulwich/patch.py:563:40-52: The type `None` doesn't support format specifiers [invalid-argument]
colour (https://github.com/colour-science/colour)
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:101:33-67: The type `floating[_16Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:101:33-67: The type `floating[_32Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:102:10-44: The type `floating[_16Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:102:10-44: The type `floating[_32Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:255:40-57: The type `floating[_16Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:255:40-57: The type `floating[_32Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:255:62-79: The type `floating[_16Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:255:62-79: The type `floating[_32Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/plotting/phenomena.py:344:13-27: The type `ndarray[tuple[Any, ...], dtype[float64 | floating[_16Bit] | floating[_32Bit]]]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/plotting/phenomena.py:672:63-70: The type `Buffer` doesn't support format specifiers [invalid-argument]
+ ERROR colour/plotting/phenomena.py:672:63-70: The type `_NestedSequence[bytes | complex | str]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/plotting/phenomena.py:672:63-70: The type `_NestedSequence[_SupportsArray[dtype]]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/plotting/phenomena.py:672:63-70: The type `_SupportsArray[dtype]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/plotting/phenomena.py:672:63-70: Incompatible types in string interpolation (expression has type `bytes`, placeholder has type `complex | float | int`) [bad-argument-type]
+ ERROR colour/plotting/phenomena.py:672:63-70: Incompatible types in string interpolation (expression has type `str`, placeholder has type `complex | float | int`) [bad-argument-type]
scikit-learn (https://github.com/scikit-learn/scikit-learn)
+ ERROR sklearn/metrics/_plot/tests/test_roc_curve_display.py:135:46-67: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR sklearn/model_selection/_validation.py:899:47-66: The type `Number` doesn't support format specifiers [invalid-argument]
+ ERROR sklearn/model_selection/_validation.py:900:42-72: The type `Number` doesn't support format specifiers [invalid-argument]
+ ERROR sklearn/model_selection/_validation.py:904:44-62: The type `Number` doesn't support format specifiers [invalid-argument]
+ ERROR sklearn/model_selection/_validation.py:904:44-62: The type `dict[Unknown, Number]` doesn't support format specifiers [invalid-argument]
+ ERROR sklearn/model_selection/_validation.py:904:44-62: The type `dict[Unknown, Unknown]` doesn't support format specifiers [invalid-argument]
+ ERROR sklearn/model_selection/_validation.py:904:69-86: The type `Number` doesn't support format specifiers [invalid-argument]
+ ERROR sklearn/model_selection/_validation.py:906:37-54: The type `Number` doesn't support format specifiers [invalid-argument]
materialize (https://github.com/MaterializeInc/materialize)
+ ERROR misc/python/materialize/feature_benchmark/benchmark_result.py:97:22-42: The type `T` doesn't support format specifiers [invalid-argument]
+ ERROR misc/python/materialize/feature_benchmark/benchmark_result.py:111:22-43: The type `T` doesn't support format specifiers [invalid-argument]
freqtrade (https://github.com/freqtrade/freqtrade)
+ ERROR freqtrade/persistence/trade_model.py:900:33-61: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR freqtrade/strategy/interface.py:1656:47-76: The type `None` doesn't support format specifiers [invalid-argument]
pwndbg (https://github.com/pwndbg/pwndbg)
+ ERROR pwndbg/aglib/dynamic.py:242:106-127: The type `Value` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/dynamic.py:242:136-155: The type `Value` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/godbg.py:393:32-41: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:362:45-56: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:366:55-66: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:369:45-56: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:386:49-58: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:433:49-58: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:479:33-44: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:490:47-58: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:503:33-44: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:540:43-54: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/elf.py:237:62-70: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/ktask.py:176:30-40: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/linkmap.py:30:52-72: The type `Value` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/linkmap.py:30:77-95: The type `Value` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/ptmalloc2.py:586:33-54: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/ptmalloc2.py:586:74-90: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/ptmalloc2.py:603:25-46: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/ptmalloc2.py:603:66-82: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/ptmalloc2.py:1374:24-35: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/gdblib/got.py:166:60-75: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/gdblib/got.py:194:80-91: The type `None` doesn't support format specifiers [invalid-argument]
comtypes (https://github.com/enthought/comtypes)
+ ERROR comtypes/client/lazybind.py:153:47-65: The type `object` doesn't support format specifiers [invalid-argument]
apprise (https://github.com/caronc/apprise)
+ ERROR apprise/plugins/aprs.py:667:33-49: Incompatible types in string interpolation (expression has type `NotifyFormat`, placeholder has type `complex | float | int`) [bad-argument-type]
+ ERROR apprise/plugins/aprs.py:667:33-49: Incompatible types in string interpolation (expression has type `OverflowMode`, placeholder has type `complex | float | int`) [bad-argument-type]
+ ERROR apprise/plugins/aprs.py:667:33-49: Incompatible types in string interpolation (expression has type `str`, placeholder has type `complex | float | int`) [bad-argument-type]
+ ERROR apprise/plugins/aprs.py:667:33-49: The type `None` doesn't support format specifiers [invalid-argument]
manticore (https://github.com/trailofbits/manticore)
+ ERROR manticore/native/cpu/arm.py:1080:42-50: The type `BitVecAnd` doesn't support format specifiers [invalid-argument]
+ ERROR manticore/native/cpu/arm.py:1309:63-74: The type `BitVec` doesn't support format specifiers [invalid-argument]
+ ERROR manticore/native/cpu/arm.py:1309:63-74: The type `BitVecAnd` doesn't support format specifiers [invalid-argument]
+ ERROR manticore/native/cpu/arm.py:1309:63-74: The type `BitVecITE` doesn't support format specifiers [invalid-argument]
+ ERROR manticore/utils/emulate.py:422:47-64: The type `None` doesn't support format specifiers [invalid-argument]
ibis (https://github.com/ibis-project/ibis)
+ ERROR ibis/backends/impala/__init__.py:704:73-88: The type `DataFrame` doesn't support format specifiers [invalid-argument]
+ ERROR ibis/backends/impala/__init__.py:704:73-88: The type `Series` doesn't support format specifiers [invalid-argument]
+ ERROR ibis/expr/operations/generic.py:176:24-40: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR ibis/expr/operations/udf.py:42:21-35: Incompatible types in string interpolation (expression has type `bytes`, placeholder has type `int`) [bad-argument-type]
+ ERROR ibis/expr/operations/udf.py:42:21-35: Incompatible types in string interpolation (expression has type `complex`, placeholder has type `int`) [bad-argument-type]
+ ERROR ibis/expr/operations/udf.py:42:21-35: Incompatible types in string interpolation (expression has type `float`, placeholder has type `int`) [bad-argument-type]
+ ERROR ibis/expr/operations/udf.py:42:21-35: Incompatible types in string interpolation (expression has type `str`, placeholder has type `int`) [bad-argument-type]
+ ERROR ibis/expr/types/relations.py:3492:20-33: The type `NumericValue` doesn't support format specifiers [invalid-argument]
+ ERROR ibis/expr/types/relations.py:3503:24-37: The type `NumericValue` doesn't support format specifiers [invalid-argument]
aiohttp (https://github.com/aio-libs/aiohttp)
+ ERROR aiohttp/connector.py:1482:36-52: The type `None` doesn't support format specifiers [invalid-argument]
async-utils (https://github.com/mikeshardmind/async-utils)
+ ERROR src/async_utils/lockout.py:83:34-53: The type `list[float]` doesn't support format specifiers [invalid-argument]
+ ERROR src/async_utils/lockout.py:152:34-53: The type `set[Future[None]]` doesn't support format specifiers [invalid-argument]
ignite (https://github.com/pytorch/ignite)
+ ERROR ignite/handlers/checkpoint.py:476:91-105: The type `Number` doesn't support format specifiers [invalid-argument]
+ ERROR ignite/utils.py:137:30-40: The type `Number` doesn't support format specifiers [invalid-argument]
+ ERROR ignite/utils.py:168:19-29: The type `Number` doesn't support format specifiers [invalid-argument]
pywin32 (https://github.com/mhammond/pywin32)
+ ERROR win32/Demos/getfilever.py:31:40-50: Incompatible types in string interpolation (expression has type `str`, placeholder has type `int`) [bad-argument-type]
+ ERROR win32/Demos/getfilever.py:31:50-64: Incompatible types in string interpolation (expression has type `str`, placeholder has type `int`) [bad-argument-type]
websockets (https://github.com/aaugustin/websockets)
+ ERROR src/websockets/sync/messages.py:89:51-64: The type `None` doesn't support format specifiers [invalid-argument]
pandas (https://github.com/pandas-dev/pandas)
+ ERROR pandas/io/formats/style_render.py:1926:18-23: The type `integer` doesn't support format specifiers [invalid-argument]
+ ERROR pandas/io/pytables.py:3423:22-46: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pandas/io/pytables.py:4243:15-39: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pandas/tests/internals/test_internals.py:130:33-38: Incompatible types in string interpolation (expression has type `float64`, placeholder has type `int`) [bad-argument-type]
+ ERROR pandas/tests/plotting/test_datetimelike.py:1736:46-54: The type `signedinteger[_NBitIntP]` doesn't support format specifiers [invalid-argument]
+ ERROR pandas/tests/scalar/period/test_period.py:884:18-44: The type `NaTType` doesn't support format specifiers [invalid-argument]
+ ERROR pandas/tests/scalar/test_na_scalar.py:38:14-22: The type `NAType` doesn't support format specifiers [invalid-argument]
+ ERROR pandas/tests/scalar/test_na_scalar.py:39:14-22: The type `NAType` doesn't support format specifiers [invalid-argument]
xarray (https://github.com/pydata/xarray)
+ ERROR xarray/coding/cftimeindex.py:147:23-32: Unrecognized format specification `!r` [invalid-argument]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes part of #4010
Test Plan