fix: delegate errors after headers are sent#379
Open
vibhor-aggr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the documented
res.headersSentguard to the generated Express app error handler.The generated template now delegates to the default Express error handler when headers were already sent, matching the guidance linked from #254. I also added a generated-output regression test so the default scaffold keeps this guard.
Refs #254.
Verification:
npm run lint./node_modules/.bin/mocha --reporter spec --check-leaks test/ --grep 'should create basic app$|should delegate errors after headers are sent'git diff --checkNote: a full
npm testrun progressed through the new regression test and then failed in the existing--css sassinstallability case because generated apps depend onnode-sass@4.14.1, whosenode-gyp@3.8.0build expects Python 2 and is incompatible with the local Node 24 toolchain. That failure is unrelated to this error-handler template change.