Remove the object-assign dependency (native Object.assign with an ES5 fallback) - #430
Open
Martin-Luther wants to merge 1 commit into
Open
Remove the object-assign dependency (native Object.assign with an ES5 fallback)#430Martin-Luther wants to merge 1 commit into
Martin-Luther wants to merge 1 commit into
Conversation
Martin-Luther
added a commit
to gina-io/gina
that referenced
this pull request
Aug 3, 2026
…s. The 9d41236 entry said the override was 'applied to the framework install tree', which a consumer would reasonably read as their own tree; measured on both package managers, it is not — npm and bun each honor overrides only in a project's own root manifest, so a project depending on gina still resolves object-assign@4.x beneath cors, byte-unchanged. The entry now states that scope plainly, points at the one-line overrides addition a consumer can make in their own root package.json, and names the upstream expressjs/cors#430 as the consumer-reaching path. Wording only — no code, no dependency, no lockfile change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
object-assignruntime dependency.lib/index.jsnow uses the nativeObject.assignwhen available (every Node.js >= 4), with a small inline fallback for the older runtimes this package still supports (engines: node >= 0.10— unchanged by this PR).Why
object-assign@4.1.1has been frozen since 2017. Supply-chain audit tooling flags it as unmaintained, and thecors -> object-assignedge propagates that flag into every downstream dependency audit.Object.assignat require time — the dependency adds an install event and a maintainer surface without changing runtime behavior on any modern platform.corsconsumer.Compatibility
enginesis untouched (node >= 0.10).Object.assign— exactly whatobject-assign@4.1.1already delegated to.assign({}, defaults, options)on plain option objects).for...inover anull/undefinedsource is a no-op in ES5, matching native's ignore-null semantics. Symbol-keyed properties do not exist on those runtimes, so the native-vs-fallback difference is unobservable there.