Skip to content

handle arbitrary slice types in sort builtin#968

Open
netliomax25-code wants to merge 2 commits into
expr-lang:masterfrom
netliomax25-code:sort-reflect-fallback
Open

handle arbitrary slice types in sort builtin#968
netliomax25-code wants to merge 2 commits into
expr-lang:masterfrom
netliomax25-code:sort-reflect-fallback

Conversation

@netliomax25-code
Copy link
Copy Markdown

sort only special-cases []any/[]int/[]float64/[]string, so a dynamically typed slice like []int64 or []uint falls through the switch and returns an empty slice with no error, silently dropping every element. Handle any slice or array through reflection like reverse and uniq do.

@antonmedv
Copy link
Copy Markdown
Member

looks like a lot of generated expressions now are falling

@netliomax25-code
Copy link
Copy Markdown
Author

Yeah, the error path was too broad. sort used to silently return empty for anything that wasn't one of the special-cased slice types, so the generated corpus has a bunch of expressions sorting maps/nil/struct slices that relied on that. Dropped the error and narrowed the reflection fallback to only pick up slices/arrays whose element kind is actually orderable (ints, uints, floats, string, bool). Everything else keeps the old no-op behavior. gen tests are green again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants