Lanl/mirrors#286
Open
Paul-Ferrell wants to merge 87 commits into
Open
Conversation
grodzki-lanl
force-pushed
the
lanl/mirrors
branch
from
791c383 to
41e7630
Compare
|
We put all mirror manipulation code into a class, and changed the |
instead of calling url and timing out, simply check that urls are correctly formated: * because the reachability of urls might differ between the stack-config and make phases. * because it slows down the unit tests (which should run quickly).
always pass the mount when creating Mirrors - the choice about whether to use a mount-specific url for the build cache is decided using the mount_specific boolean flag the "enabled" boolean flag for turning caches on and off was redundant - the mirrors.yaml file describes the mirrors to use - mirrors.yaml will typically be a static file injected into pipelines, and the only use case where you might want to modify its behavior is when doing manual testing - in which case comment out. flipping a switch. - if we want, we can add CLI flags for turning mirror selection.
- resolve and validate all mirror inputs (urls, gpg keys) in Mirrors.__init__ - builder writes mirror artifacts instead of computing them - store buildcache, bootstrap and source_caches as separate members - decode gpg keys to in-memory bytes; expose config_files()/gpg_key_paths() - fix always-true magic gpg key check; reject non-key data - fix build cache mirror name mismatch in cache-force and --cache pushes - keep file:// urls as strings
- rename sourcecache to sourcemirror (for pre-populated source mirrors)
- add sourcecache for read through source caching
- after downloading a source, add it to the cache so that it does
not have to be downloaded again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've added a new config file at the system level -
mirrors.yamlIt allows you to configure regular mirrors, build caches (including public keys), and bootstrap mirrors.mirrorattribute of recipe object with amirrorsattribute that works quite differently.