fix(cardputer-ci): Fix CI build of cardputer which consumes more flash on older ESP-IDF#670
Merged
Merged
Conversation
…h on older ESP-IDF
|
✅Static analysis result - no issues found! ✅ |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the m5stack-cardputer example’s flash partitioning so the CI build has a larger/appropriate memory layout on older ESP-IDF versions that produce bigger binaries, aligning this example with other repo examples that use a custom partition table at 0x9000.
Changes:
- Enables a custom partition table for the cardputer example (
CONFIG_PARTITION_TABLE_CUSTOM*) and sets the partition table offset to0x9000. - Adds an example-local
partitions.csvdefining NVS/PHY/app/littlefs partitions sized to fit within 8MB flash.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| components/m5stack-cardputer/example/sdkconfig.defaults | Enables custom partition table usage and points to partitions.csv with offset 0x9000. |
| components/m5stack-cardputer/example/partitions.csv | Defines the custom partition layout (NVS/PHY/factory app/littlefs) for the example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.