feat(math): Update piecewise_linear to take span rather than vector#667
Merged
Conversation
|
✅Static analysis result - no issues found! ✅ |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates piecewise_linear to accept a std::span of point pairs instead of owning a std::vector, improving API flexibility and enabling use with fixed-size containers.
Changes:
- Changed
piecewise_linearparameter type fromstd::vector<...>&tostd::span<const ...>. - Simplified boundary checks using
front()/back()and streamlined interpolation variables via structured bindings. - Updated the math example to use
std::arrayfor one of the point tables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| components/math/include/fast_math.hpp | Switches piecewise_linear to std::span and refactors interpolation/bounds logic accordingly. |
| components/math/example/main/math_example.cpp | Updates one lookup table container to std::array to better align with the new std::span API. |
| [[maybe_unused]] static float piecewise_linear(const std::vector<std::pair<float, float>> &points, | ||
| [[maybe_unused]] static float piecewise_linear(std::span<const std::pair<float, float>> points, | ||
| float x) { | ||
| if (points.size() == 0) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.