Fix epic plan revision loop - #1
Open
eshulman2 wants to merge 10 commits into
Open
Conversation
Enables opt-in/opt-out for PR-based PRD approval via the CLI: forge project-setup OSAC --prd-proposals-repo osac-project/enhancement-proposals forge project-setup OSAC --prd-proposals-repo "" # disable Also adds delete_project_property to JiraClient for the opt-out case. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…sals-repo feat: add --prd-proposals-repo flag to forge project-setup CLI
…n-loop-upstream Fix epic plan revision loop
When a user requested plan revision at the plan_approval_gate, regenerate_all_epics archived old epics and called decompose_epics, but decompose_epics never forwarded feedback_comment to the agent. The LLM had no knowledge of the user's request, so it regenerated the same epic structure without incorporating any changes. Fix: thread feedback_comment from state into the context dict in decompose_epics, and append it as a "Revision Feedback" section to the decompose-epics prompt in generate_epics when present. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- Import regenerate_epic_tasks from task_generation - Add resume mapping in route_by_ticket_type - Add graph node, edge back to task_approval_gate - Extend both route_entry and task_approval_gate conditional-edges dicts - Add test for route_by_ticket_type(regenerate_epic_tasks) resume routing Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
eshulman2
force-pushed
the
fix/epic-plan-revision-loop
branch
from
June 23, 2026 08:00
28be7a0 to
a2e03ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
regenerate_all_epicsandupdate_single_epicat their own nodes instead of raw decompositionTests
uv run pytest tests/unit/workflow/nodes/test_epic_decomposition.py tests/unit/orchestrator/gates/test_plan_approval.py tests/unit/workflow/feature/test_workflow.pyuv run ruff check src/forge/workflow/nodes/epic_decomposition.py src/forge/workflow/feature/graph.py tests/unit/workflow/nodes/test_epic_decomposition.py tests/unit/workflow/feature/test_workflow.py