Conversation
CLAUDE.md: current build/test/CI reality (scikit-build-core pip path, conda-forge distribution, the Python TIFF accuracy suite, ci.yml + release.yml instead of the removed conda-build.yml). CONTRIBUTING.md: branching model and PRs target develop; release flow goes through a develop -> main PR. ci.yml: drop the retired conda-forge branch from the push triggers. ci-readme.md described a workflow that no longer exists; removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Reviewer's GuideDocumentation and CI configuration are updated to codify the feature → develop → PR → main branching/release model, align build/test instructions with the current scikit-build-core + conda-forge pipeline, and remove obsolete CI artifacts and triggers. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (5)
🧰 Additional context used🪛 LanguageToolCLAUDE.md[uncategorized] ~99-~99: The official name of this software platform is spelled with a capital “H”. (GITHUB) [uncategorized] ~99-~99: The official name of this software platform is spelled with a capital “H”. (GITHUB) 🪛 markdownlint-cli2 (0.22.1)CONTRIBUTING.md[warning] 5-5: Link text should be descriptive (MD059, descriptive-link-text) 🔇 Additional comments (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe CI workflow's push trigger is restricted to ChangesBranching and CI Documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The branching/release model is now described in both CONTRIBUTING.md and CLAUDE.md; consider consolidating this into a single canonical section and linking to it to avoid future drift between the two descriptions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The branching/release model is now described in both CONTRIBUTING.md and CLAUDE.md; consider consolidating this into a single canonical section and linking to it to avoid future drift between the two descriptions.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
Updates project documentation and CI triggers to match the post-4.0.0 branching/release workflow (feature/fix work targeting develop, with releases promoted via develop → main PRs) and removes obsolete CI documentation.
Changes:
- Document the
feature/*→develop→ PR →mainbranching and release flow inCONTRIBUTING.mdandCLAUDE.md. - Align
CLAUDE.mdwith the canonicalpip install .(scikit-build-core) build path, conda-forge distribution, and current CI workflows. - Update CI push triggers to stop running on the retired
conda-forgebranch and delete the unusedci-readme.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CONTRIBUTING.md | Adds branching model + updates release checklist to reflect develop → main release PR flow. |
| CLAUDE.md | Updates canonical build/test/release documentation and current CI workflow references. |
| .github/workflows/ci.yml | Removes conda-forge from push branch triggers. |
| ci-readme.md | Removes obsolete CI documentation file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+14
to
+16
| # Canonical Python build (scikit-build-core drives CMake + nvcc and installs | ||
| # the package; run from the repository root in an env with cmake/ninja/numpy) | ||
| pip install . --no-build-isolation -v |
|
|
||
| - `main` is protected (PR + green CI required); `develop` is the integration branch. | ||
| - Work on `feature/<name>` branches cut from `develop`, merge them into `develop`, and open a PR `develop` → `main` when a release-worthy state is reached. | ||
| - Releases are tag-driven: bump `pyproject.toml` + `CHANGELOG.md`, work through TESTING.md (the GPU accuracy suites cannot run in CI), merge to `main`, then `git tag vX.Y.Z && git push origin vX.Y.Z`. `release.yml` enforces tag == version and publishes the GitHub Release; conda-forge's autotick bot then opens a feedstock version-bump PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the documentation in line with the post-4.0.0 reality and establishes the branching model:
develop; releases go through adevelop→mainPR), release checklist updated to match.conda-build.ymlno longer exists).conda-forgebranch from push triggers.Branch cleanup done alongside:
conda-forgedeleted (merged), 2019-eratestingandexperimental/new-process-mutexpreserved asarchive/*tags and deleted, PR #7 retargeted todevelop.🤖 Generated with Claude Code
Summary by Sourcery
Document the updated feature → develop → PR → main branching and release workflow and align CI/docs with the current build and distribution setup.
CI:
Documentation: