pre-built wee8: add dependencies and patches - #5136
Open
dcillera wants to merge 2 commits into
Open
Conversation
dcillera
commented
Aug 19, 2026
dcillera
commented
Contributor
Document current state of wee8 prebuilt integration: - Infrastructure 95% complete - Blocked on transitive dependency issue - Clear path forward documented The prebuilt wee8 infrastructure is working (bins-v0.2.8 published, platform selection working), but integration is blocked because @proxy_wasm_cpp_host//:v8_lib needs abseil headers that were previously provided as transitive deps by @v8//:wee8. Solution: Add abseil deps to _WEE8_BUILD template in bazel/v8/wee8_prebuilt.bzl, then cut v0.4.7 release. See CLAUDE.md V8 section for details. Signed-off-by: Dario Cillerai <dcillera@redhat.com>
✅ Deploy Preview for nifty-bassi-e26446 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
phlax
reviewed
Aug 19, 2026
phlax
left a comment
phlax
left a comment
Member
There was a problem hiding this comment.
probably we will need to setup some python deps in this repo for the build
| load("@rules_cc//cc:cc_binary.bzl", "cc_binary") | ||
| load("@rules_python//python:defs.bzl", "py_binary", "py_test") | ||
| -load("@v8_python_deps//:requirements.bzl", "requirement") | ||
| +load("@base_pip3//:requirements.bzl", "requirement") |
dcillera
force-pushed
the
adjust-dependencies_and_patches
branch
2 times, most recently
from
August 19, 2026 17:13
53d11c2 to
5ff5a87
Compare
Apply Envoy's V8 patches before building prebuilt wee8 libraries to ensure ABI compatibility with Envoy's expectations. Changes: - Add bazel/v8/patches/ directory with Envoy V8 patches: - v8.patch (original Envoy patch, kept for reference) - v8_no_python_load.patch (modified: Python dep change removed) - v8_novtune.patch, v8_ppc64le.patch, v8_python.patch (unchanged) - MODULE.bazel: Add archive_override for V8 14.6.202.10 with patches - Add V8 Python requirements (bazel/v8/requirements.txt) for code generation - wee8_prebuilt.bzl: Add dependencies to enable Envoy builds: - abseil dependency (@abseil-cpp//absl/strings:str_format) - V8_ENABLE_WEBASSEMBLY define - third_party include path for wasm-api headers Why v8_no_python_load.patch? Envoy's v8.patch changes @v8_python_deps to @base_pip3, but bzlmod repository visibility prevents @v8+ from seeing @base_pip3 defined in toolshed. Since wee8 is a static library build (not a Python runtime), we removed the Python load line change. Other critical patches (pointer compression, compiler flags, external deps) remain intact. Next steps: CI will build patched wee8 tarballs, then cut bins-v0.2.9 release. Build time savings when complete: 30-120 min → seconds Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Dario Cillerai <dcillera@redhat.com>
dcillera
force-pushed
the
adjust-dependencies_and_patches
branch
from
August 19, 2026 17:48
5ff5a87 to
2d65fa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.