quic: Reduce QuicheMemSlice memory footprint from ~968 B to ~120 B - #46724
Open
filipcacky wants to merge 2 commits into
Open
quic: Reduce QuicheMemSlice memory footprint from ~968 B to ~120 B#46724filipcacky wants to merge 2 commits into
filipcacky wants to merge 2 commits into
Conversation
Signed-off-by: Filip Cacky <filip.cacky@cdn77.com>
Contributor
Author
|
We noticed QUIC send buffers using more memory than necessary on connections over congested/lossy networks, where slices may need to stay in the buffer for longer periods of time. In our case some internal filters fragment buffers and end up with many small slices. I don't think this is a significant issue for stock Envoy. In any case this reduces the per-slice overhead and removes the Also removed the QuicheMemSliceImpl, which isn't required by quiche anymore. |
Signed-off-by: Filip Cacky <filip.cacky@cdn77.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: quic: Reduce QuicheMemSlice memory footprint from ~968 B to ~120 B
Additional Description:
Change
QuicheMemSlicebacking storage fromBuffer::OwnedImpltoBuffer::SliceDataImpl. This reduces the memory footprint for one slice from ~968 B from the buffer to ~120 B and removes theOwnedImplctor from the hot path.Risk Level: Low
Testing: Added tests for
extractImmutableFrontSliceDocs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A