fix(webhook): skip review webhooks without reviewer id or timestamp#181
Closed
jaso0n0818 wants to merge 1 commit into
Closed
fix(webhook): skip review webhooks without reviewer id or timestamp#181jaso0n0818 wants to merge 1 commit into
jaso0n0818 wants to merge 1 commit into
Conversation
Guard pull_request_review submissions that lack review.user.id or review.submitted_at, matching the backfill path in github-fetcher.service.ts. Prevents webhook 500s and NOT NULL upsert failures on ghost reviewers. Co-authored-by: Cursor <cursoragent@cursor.com>
jaso0n0818
force-pushed
the
fix/review-handler-missing-reviewer-guard
branch
from
7c1ac9c to
b6406a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard
pull_request_reviewwebhook handling whenreview.user.idorreview.submitted_atis missing.Related Issues
Parity with backfill review ingestion in
github-fetcher.service.ts.Type of Change
Testing
npm run lintnpm run buildDuplicate check
review.handler.tsWhy
String(review.user.id)throws on ghost/deleted reviewers and causes webhook delivery failures;submitted_atis NOT NULL in the reviews schema.