Skip to content

fix: normalize token address casing in market data retrieval #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kvhnuke wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −5
Open

fix: normalize token address casing in market data retrieval #809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/extension/src/providers/ethereum/libs/transaction/decoder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,15 @@ const decodeTx = async (
tokenTo = decodedInfo.tokenTo!;
}
await marketData
.getMarketInfoByContracts([tx.to!], network.coingeckoPlatform!)
.getMarketInfoByContracts(
[tx.to!.toLowerCase()],
network.coingeckoPlatform!,
)
.then(marketInfo => {
if (marketInfo[tx.to!]) {
currentPriceUSD = marketInfo[tx.to!]!.current_price ?? 0;
CGToken = marketInfo[tx.to!]!.id;
if (marketInfo[tx.to!.toLowerCase()]) {
currentPriceUSD =
marketInfo[tx.to!.toLowerCase()]!.current_price ?? 0;
CGToken = marketInfo[tx.to!.toLowerCase()]!.id;
}
});
} else {
Expand All @@ -82,7 +86,7 @@ const decodeTx = async (
return {
isContractCreation,
dataHex: bufferToHex(dataDecoder.data),
toAddress: tx.to!,
toAddress: tx.to!.toLowerCase(),

@coderabbitai coderabbitai Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win

Crash on contract-creation transactions.

tx.to can be undefined/null (see Line 17: isContractCreation = tx.to ? false : true, and the optional toAddress?: string in DecodedTx). The ! non-null assertion is compile-time only and has no runtime effect, so calling .toLowerCase() unconditionally will throw a TypeError for every contract-creation transaction, where previously tx.to was simply passed through as-is without any method call.

🐛 Proposed fix 
-    toAddress: tx.to!.toLowerCase(),
+    toAddress: tx.to?.toLowerCase(),
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
toAddress: tx.to!.toLowerCase(),
toAddress: tx.to?.toLowerCase(),
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/extension/src/providers/ethereum/libs/transaction/decoder.ts` at
line 89, The DecodedTx mapping in decoder.ts is still calling toLowerCase on
tx.to via a non-null assertion, which will crash for contract-creation
transactions where tx.to is absent. Update the decoding logic around the tx.to
assignment so it safely handles undefined/null values, preserving the existing
behavior for contract creation by leaving toAddress unset or passing through the
missing value without invoking string methods.

decodedHex: dataDecoder.decode().values,
decoded: dataDecoder.decode().decoded,
tokenDecimals,
Expand Down
Loading