Fix ARM panic when a code section has no mapping symbols#365
Closed
SAY-5 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Author
|
Closing as duplicate of #359. Happy to contribute the test fixture separately if wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
report generatepanics with an index-out-of-bounds in the ARM arch when a code section contains bytes but is not covered by any mapping symbol (no$a/$t/$dand noSTT_FUNCpointing into it).get_mapping_symbolsinserts an entry for every code section, sodisasm_modes.get(§ion_index)returnsSome(empty_slice)and thefallback_mappingspath is skipped, leavingmapping_symbols[first_mapping_idx]to index an empty slice.Treat an empty mapping-symbol list the same as a missing one so the ARM fallback is used. Added a test with a minimal ARM object (from the issue) whose
.texthas onlySTT_SECTIONand external symbols; it panics before this change and passes after.Fixes #352