Fix poppler benchmark environment flags - #27544
Open
brendandahl wants to merge 1 commit into
Open
Conversation
Preserve existing environment flags in the test library builder instead of overwriting them. This ensures caller-provided optimization settings are maintained. Set CXXFLAGS alongside CFLAGS to ensure C++ dependencies compile with the correct settings. Pass environment overrides to the freetype dependency to fix the poppler benchmark build.
sbc100
reviewed
Aug 14, 2026
| env_init.setdefault('CFLAGS', cflags) | ||
| env_init.setdefault('CXXFLAGS', cflags) | ||
| # Append library-specific cflags without overwriting caller-provided optimizations | ||
| env_init['CFLAGS'] = f"{env_init.get('CFLAGS', '')} {cflags}".strip() |
Collaborator
There was a problem hiding this comment.
How about env_init.setdefault('CFLAGS', '') += cflags ?
Collaborator
Author
There was a problem hiding this comment.
Can't do += with a function call.
sbc100
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve existing environment flags in the test library builder instead of overwriting them. This ensures caller-provided optimization settings are maintained.
Set CXXFLAGS alongside CFLAGS to ensure C++ dependencies compile with the correct settings. Pass environment overrides to the freetype dependency to fix the poppler benchmark build with LTO.