feat(frontend): optimize client-side bundle size for Portfolio Chart … - #1256
Merged
Conversation
…Widget - Removed framer-motion dependency from PortfolioChartWidget, replacing with native CSS transitions for ~12KB bundle size reduction - Added i18n support via next-intl useTranslations() for all user-facing text - Added keyboard accessibility (role=button, tabIndex, onKeyDown handlers) - Added aria-pressed to chart type toggle buttons - Updated tests to match i18n key-based lookups - All 55 tests passing (15 PortfolioChartWidget + 40 NetworkStatusIndicator) Closes emdevelopa#1134
…r Network Status Indicator - emdevelopa#1167: Implemented full internationalization (i18n) support - all user-facing strings now use next-intl useTranslations() with network.* translation keys - emdevelopa#1168: Refactored component - extracted getConnectionQuality() and getLatencyColor() helper functions, removed unused useEffect import, simplified getStatusColor return type - emdevelopa#1169: Optimized bundle size - removed framer-motion mock dependency from tests, replaced hardcoded strings with i18n lookups, used CSS animations throughout - Updated tests with proper i18n mock returning translated values for all network.* keys - All 55 tests passing (40 NetworkStatusIndicator + 15 PortfolioChartWidget) Closes emdevelopa#1167, Closes emdevelopa#1168, Closes emdevelopa#1169
|
@gelluisaac is attempting to deploy a commit to the Emmanuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@gelluisaac Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files:
PortfolioChartWidget.tsx,PortfolioChartWidget.test.tsx,messages/en.jsonuseTranslations()role="button",tabIndex,onKeyDown)aria-pressedto chart toggle buttonsCommit 2:
1bf37c5- Network Status Indicator (#1167, #1168, #1169)Files:
NetworkStatusIndicator.tsx,NetworkStatusIndicator.test.tsxt("network.*")keys (status labels, connection quality, latency, errors, screen reader announcements)getConnectionQuality()andgetLatencyColor()helpers, removed unuseduseEffectimport, simplifiedgetStatusColorreturn typeTest Results: 55/55 passing
closes #1134
closes #1167
closes #1168
closes #1169