fix: reset stale TTL on reused FlushRecord and bump rocksdb-cloud roll guard - #552
Merged
Merged
Conversation
WalkthroughThe PR updates the ChangesRocksDB Cloud update
Blob TTL reset
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
liunyl
approved these changes
Aug 11, 2026
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
FlushRecord::SetNonVersionedPayload reuses the BlobTxRecord slot across data-sync scan batches but only cleared value_, leaving the previous record's ttl_ behind. A no-TTL object flushed into a contaminated slot was then written to the KV store with another key's expiration: the RocksDB(-Cloud) read path and TTL compaction filter treat it as expired, so the key silently disappears once it is evicted from memory. Reset ttl_ to UINT64_MAX (BlobTxRecord's "no TTL" sentinel) on every reuse. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
thweetkomputer
force-pushed
the
update-rocksdb-cloud-roll-guard
branch
from
August 11, 2026 06:54
a4efc53 to
d2c2aea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
third_party/src/rocksdb-cloudto7b4210e(eloqdata/rocksdb-cloud main), which publishes the smallest-file-number guard object inRollNewCookiebefore the new epoch becomes reachable (Upgrade github workflow DoozyX/clang-format-lint-action to v0.18 #20) and fixes the const-qualification compile error inPutSmallestFileNumberObject([Feature]: Move table stats broadcast into data sync worker #21).FlushRecord::SetNonVersionedPayloadreuses itsBlobTxRecordacross data-sync scan batches but only clearedvalue_, leaving the previous record'sttl_behind. A no-TTL object flushed into a contaminated slot was written to the KV store with another key's expiration, so the read path and the TTL compaction filter treated it as expired and the key disappeared once evicted from memory — no restart required. Resetttl_toUINT64_MAX(the "no TTL" sentinel) on every reuse.🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Chores