Fix attendance_app: await async readData() so /students and /download return data - #379
Open
eeshsaxena wants to merge 1 commit into
Open
Fix attendance_app: await async readData() so /students and /download return data#379eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
readData() returns a MongoDB find().toArray() promise, but /students did
res.json(readData()) and /download did readData().map(...) with no await.
So /students serialized a pending promise as {} and /download crashed on
.map (a promise has no .map). Awaiting the promise returns the actual
student list from both routes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attendance_app/server.jsreads students from MongoDB viareadData(), which returns afind().toArray()promise. Two routes used it without awaiting:GET /studentsdidres.json(readData()), so it serialized a pending promise and returned{}instead of the student list.GET /downloaddidreadData().map(...), which throws because a promise has no.map, so the CSV export crashed with a 500.This awaits
readData()in both handlers so they return the actual student data. Small, contained change to just those two routes.