Skip to content

Gtk4Prep: Use Gtk.SourceCompletionWords#1765

Merged
danirabbit merged 4 commits into
masterfrom
jeremypw/completionproviderwords
Jul 10, 2026
Merged

Gtk4Prep: Use Gtk.SourceCompletionWords#1765
danirabbit merged 4 commits into
masterfrom
jeremypw/completionproviderwords

Conversation

@jeremypw

@jeremypw jeremypw commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

It is not clear why we implement our own word completion plugin when there is a provider already provided by Gtk. Our provider handler a wider range of characters but these are generally ones not allowed in Vala code names (and there are some flaws in our provider).

Pushing this for testing to see whether the Gtk provider is sufficient for Code, in which case a lot of code can be dropped and the porting made easier.

Converting our provider to GtkSource5 requires significant changes although not too hard.

If we are going to have our own provider it might be more useful to get proposals from the Vala symbols pane including info like function signatures and from relevant .vapi files.

Fixes #851
Fixes #1527

@danirabbit danirabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it looks like our word completion plugin is super duper old so maybe it just predates better completion in Gtk.SourceView.

I searched for issues related to word completion to check for regressions and none found! Let's go 🚀

@danirabbit danirabbit merged commit 82d2e94 into master Jul 10, 2026
6 checks passed
@danirabbit danirabbit deleted the jeremypw/completionproviderwords branch July 10, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Word completion omits first word in document until refreshed Word completion retains deleted words

2 participants