fix(ci): install client packages in example deploy jobs (unblocks burn redeploy)#4727
Merged
Merged
Conversation
The deploy step unconditionally builds @electric-sql/client, @electric-sql/experimental and @electric-sql/react, but the install step only installs the example's own dependency graph. For examples with no workspace dependency on those packages (burn), the build fails with 'shx: not found' and the deploy never runs — which is why the burn demo stayed down (crash-looping on a revoked ANTHROPIC_KEY) even after #4725 merged: its deploy job failed before sst ran, masked by continue-on-error. Add the three packages to the install filters in both deploy workflows, and document burn's deployment in its README — which also puts examples/burn in the changed-deployable matrix so merging this redeploys it with the rotated key and Haiku config. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
balegas
requested review from
KyleAMathews,
alco,
icehaunter,
kevin-dp,
magnetised,
msfstef,
paulharter,
robacourt,
samwillis and
thruflo
as code owners
July 15, 2026 23:53
thruflo
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
@electric-sql/client,@electric-sql/experimentaland@electric-sql/reactto the pnpm install filters indeploy_examples.ymlanddeploy_all_examples.yml, and adds a short Deployment section toexamples/burn/README.md.Why — burn is still down after #4725
The deploy job's Deploy step unconditionally builds the three client packages before
sst deploy, but the Install step only installs the example's own dependency graph (pnpm --filter "<example>..."). Burn is an Elixir app with no workspace dependency on those packages, so their devDeps (shx,tsup) are missing and the build dies:The job failure is masked by
continue-on-error: true(run 29458958432 shows green with a failedDeploy burnjob), so #4725 never actually redeployed burn — the ECS service is still on task definition revision 1, crash-looping on the revokedANTHROPIC_KEY.All other examples pass because they happen to depend on the client packages via the workspace, which pulls them into the install.
Redeploy
The README change puts
examples/burnin thechanged-deployablematrix, so merging this PR triggers the burn deploy — now unblocked — which picks up the rotatedANTHROPIC_KEYand the Haiku model config from #4725.🤖 Generated with Claude Code