Fix: Allow sql.s3_to_postgres() to rely on an IAM role - #88
Open
johncmerfeld wants to merge 1 commit into
Open
Conversation
johncmerfeld
force-pushed
the
fix/s3-postgres-iam-role
branch
from
May 13, 2026 14:30
e1f6c6f to
60a53f9
Compare
jayckaiser
approved these changes
May 14, 2026
jayckaiser
left a comment
jayckaiser
left a comment
Collaborator
There was a problem hiding this comment.
Some personal thoughts about whitespace formatting, but the PR is solid. Approved!
Contributor
Author
|
@jayckaiser is there a reason we can't merge and release this? Would be great for it to be default behavior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're aiming to move away from handling S3 credentials directly in Airflow connections. Removing them from the connection objects is one thing, but this SQL snippet also expects them to be present, causing errors when they are not defined: