Provide pre-built musl targets - #88
Conversation
Support building statically-linked loon CLI binaries on Linux, using musl libc.
Add -musl targets
Upgrade actions ot Node24
|
@vazub is attempting to deploy a commit to the ecto's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Choji review — Looks good The musl target additions are well-structured and the build logic is correct. The only notable issue is a version mismatch between No findings — looks good. Reviewed |
![chojiai[bot]](https://avatars.githubusercontent.com/in/3490784?s=60&v=4){kind=small}
| os: ubuntu-latest | ||
| - target: aarch64-unknown-linux-gnu | ||
| os: ubuntu-latest | ||
| - target: x86_64-unknown-linux-musl |
There was a problem hiding this comment.
Critical · Correctness — actions/checkout@v6 does not exist and will break every release build
The latest published release of actions/checkout is v4; v6 does not exist, so the checkout step will fail with an action-not-found error on every matrix leg. Revert to actions/checkout@v4.
| - target: x86_64-unknown-linux-musl | |
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
@chojiai Finding is incorrect, version does exist and does not break anything, as witnessed here https://github.com/vazub/loon/actions/runs/31190168270
| @@ -48,7 +73,7 @@ jobs: | |||
| tar czf "$ARCHIVE" loon | |||
There was a problem hiding this comment.
Critical · Correctness — actions/upload-artifact@v6 does not exist and will break artifact uploads for every build target
The latest published release of actions/upload-artifact is v4; v6 does not exist, causing every build leg to fail at the upload step. Revert to actions/upload-artifact@v4.
| tar czf "$ARCHIVE" loon | |
| - uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
@chojiai Finding is incorrect, version does exist and does not break anything, as witnessed here https://github.com/vazub/loon/actions/runs/31190168270
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/download-artifact@v4 | ||
| - uses: actions/download-artifact@v7 |
There was a problem hiding this comment.
Critical · Correctness — actions/download-artifact@v7 does not exist and will break the release job
The latest published release of actions/download-artifact is v4; v7 does not exist, so the release job that collects all artifacts will fail before it can publish anything. Revert to actions/download-artifact@v4.
| - uses: actions/download-artifact@v7 | |
| - uses: actions/download-artifact@v4 |
There was a problem hiding this comment.
@chojiai Finding is incorrect, version does exist and does not break anything, as witnessed here https://github.com/vazub/loon/actions/runs/31190168270
Avoids wasting time on tools compilation with every release.
Cross should be installed for aarch64-musl matrix leg only, to minimize resource waste.
Dismissing prior approval to re-evaluate f1e3730.
|
@chptung — here's where things actually stand: The previous Choji findings flagged the The only open blocker visible in CI is the Vercel authorization — a team member on ecto's projects needs to approve the deployment. That's unrelated to the workflow changes in this PR. The PR itself looks solid:
Nothing blocking on the code side. 🟢 Heads up — your GitHub is linked to a Choji account, but not this repository's team, so I can't use your team's knowledge base here. Ask a team admin to add you, or switch your active team in Choji settings. - Choji |
2 participants
Closes #48.
As a minor improvement, also fixes Node20 deprecation warning for action runners.