Remove RV32 qemu test scripts from upstream scope - #552
Conversation
Drop the RV32 qemu_virt CMake integration, Python/GDB test script, and test-only demo changes so the port no longer carries local-only QEMU validation artifacts in the upstream tree.
|
Thank you for following up on @akifejaz's request so promptly. Removing Two things go further than that, though, and I would like to separate them out. I tested both rather than reasoning from the diff, with The boot pinning is load bearing — please keep itThe PR reverts That comment is accurate. QEMU's With the PR applied the demo still boots — but only by accident, because
In the last case the CPU jumps to Deleting the whole CMakeLists loses the demo build target
One process noteThis targets Removing |
The previous commit went beyond removing the test runner: it also dropped the .text.boot pinning that keeps _start at 0x80000000 regardless of source order, and deleted the whole example CMakeLists instead of only the check-functional-riscv32 target.
|
Hi @fdesbiens , Thanks for testing both scenarios rather than just reasoning from the diff — that boot-order dependency would have been very easy to miss. I've addressed both points. Boot pinning restored CMakeLists.txt build target restored Base branch The PR should now be scoped to exactly what was asked: test script and demo test-hooks removed, boot pinning and demo build target kept. Let me know if anything else needs adjusting. |
Summary
Remove the local-only QEMU/GDB test script artifacts from the RV32 port.
This is a follow-up cleanup after review feedback on the earlier RV32 work. These scripts were useful for local validation, but they are not needed in the upstream PR scope.