Skip to content

Removed the last two prebuilt archives from the source tree - #403

Merged
fdesbiens merged 1 commit into
eclipse-threadx:devfrom
yf13:drop-binary
Aug 15, 2026
Merged

Removed the last two prebuilt archives from the source tree#403
fdesbiens merged 1 commit into
eclipse-threadx:devfrom
yf13:drop-binary

Conversation

@yf13

@yf13 yf13 commented Sep 2, 2024

Copy link
Copy Markdown

A few library files exist in the source tree now, they look like parts of the toolchain thus should be dropped?

$ find . -iname '*.a'
./ports_module/cortex_m0+/gnu/example_build/sample_threadx_module_manager/libgcc.a
./ports_module/cortex_m3/iar/example_build/stm32f2xx_library.a
./ports/arm11/gnu/example_build/libnosys.a

Maintainer note, added when retargeting this to dev.

Confirmed, and the repository's own rules already agree: .gitignore:23 is *.a, and it matches both remaining archives. They survive only because ignore rules do not untrack files that were committed before the rule existed. These are the last two .a files in the tree.

Neither has a consumer. sample_threadx_module_manager/ has no build script at all — just sources, a linker script and an Arm DS launch configuration — and nothing in that port mentions libgcc. stm32f2xx_library.a is referenced nowhere in the repository, and being a prebuilt vendor binary with no recorded provenance it is also the kind of file worth not shipping.

There is precedent: 6.1.10 removed a dozen committed libc.a and libgcc.a archives across arm9, arm11, cortex_a7/a8/a9/a15, m0/m3/m4/m7 and r4/r5 under "Removal of unneeded files". This PR catches two the sweep missed.

Rebased onto dev and retargeted from master. The third file in the original change, ports/arm11/gnu/example_build/libnosys.a, is already gone from dev — removed by #594 — so the rebase dropped that deletion and the remaining two apply cleanly.

One consequence worth recording separately: the 6.1.10 sweep removed those archives without updating the scripts that link them, so ports/arm9 and ports/arm11 examples now fail with cannot find libc.a / libgcc.a / libnosys.a. That is not caused by this PR and is being fixed on its own.

@fdesbiens
fdesbiens changed the base branch from master to dev August 15, 2026 19:35
This drops a few archive files from the source tree as they belong
to the toolchain.

Signed-off-by: Yanfeng Liu <yfliu2008@qq.com>
@fdesbiens fdesbiens changed the title Drop static library files Removed the last two prebuilt archives from the source tree Aug 15, 2026
@fdesbiens
fdesbiens merged commit 1491705 into eclipse-threadx:dev Aug 15, 2026
1 check passed
akifejaz pushed a commit to akifejaz/threadx that referenced this pull request Aug 17, 2026
This drops a few archive files from the source tree as they belong
to the toolchain.

Signed-off-by: Yanfeng Liu <yfliu2008@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants