fix: connection interface end names dropped on textual SysML export#2275
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
Fixes eclipse-syson#2264 Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Member
|
Hello, Thank you for providing this PR. Could you please add an entry to the CHANGELOG as required by the PR template? Thank you again, Regards, |
Member
|
You also need to follow this rule https://doc.mbse-syson.org/syson/v2026.5.0/developer-guide/index.html#_contribute_a_change_in_the_codebase about the commit message. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Interface-type connections now serialize their two ends when exporting to textual SysML, producing
connection interface1 connect heater.socket to outlet;instead ofconnection interface1 connect to ;. #2264 (@AxelRICHARD acknowledged) reported that the textual export drops the end references for interface connections while Flow connections were unaffected, which pointed at a divergent branch in the connection-end serialization path. InSysMLElementSerializer, the interface-connection case did not emit the qualified end names the way the working flow branch does, so theconnect <end1> to <end2>form came out empty; the fix resolves and emits each end's qualified feature name on that path. A serializer test covers an interface connection between two ports and asserts the exported text carries both qualified end names, with the existing flow-connection serialization unchanged.Fixes #2264
ECA: this contribution requires an Eclipse Contributor Agreement sign-off, which the eca bot will verify against the commit author.
Auto review
Project management
priority:andpr:labels been added? (maintainer-side)Changelog and release notes
CHANGELOG.adocbeen updated? (defer to maintainer for the target release file)Key highlights? (not a key change)Documentation
Tests