fix some export bugs#2509
Open
mariusheine wants to merge 9 commits into
Open
Conversation
Test Results136 tests ±0 136 ✅ ±0 8m 37s ⏱️ +9s Results for commit 31f7a18. ± Comparison against base commit 65241ae. This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
| private static void fillSheet(final Sheet sheet, final List<TableRow> rows, | ||
| final int rowIndex, final int columnCount, | ||
| final boolean inlineFootnote) { | ||
| private static void fillSheet(final Workbook workbook, final Sheet sheet, |
Contributor
There was a problem hiding this comment.
@mariusheine you can get the wookbook through sheet, isn't? 😄
| .setFont(workbook.getFontAt(sheet.getRow(0) | ||
| .getCell(1) | ||
| .getCellStyle() | ||
| .getFontIndex())); |
Contributor
There was a problem hiding this comment.
@mariusheine pls explain here als comment, why we take the font at the cell as default
Comment on lines
+192
to
+194
| protected String getRemarkColumnPosition() { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
@mariusheine pls this function as abstract, almost pt1 table have the remark column
TruongQuangSB
requested changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: