feat: add TimeDaemon CIT with pip hub infrastructure by gordon9901 · Pull Request #122 · eclipse-score/time

gordon9901 · 2026-07-09T08:51:40Z

This PR adds TimeDaemon component integration tests with pip hub infrastructure (part 1 of 3):

Add three independent pip hubs for TimeDaemon, TimeSlave, and MIT test suites
Add score_test_scenarios framework dependency with compatibility patch for score_baselibs 0.2.7
Add TimeDaemon CIT covering daemon lifecycle, control flow, IPC, SVT, and verification pipeline
Fix visibility for shm_ptp_engine and svt_handler to allow access from test scenarios

Part of #56

test QNX

github-actions · 2026-07-09T08:52:50Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: a9545459-efd5-41ab-9c32-7573183fe9ed
Computing main repo mapping: 
WARNING: /home/runner/work/time/time/MODULE.bazel:13:7: The attribute 'compatibility_level' in module() is a no-op and will be removed in a future Bazel release. Please remove it from your MODULE.bazel file.
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (33 packages loaded, 10 targets configured)

Analyzing: target //:license-check (101 packages loaded, 277 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3113 targets configured)

Analyzing: target //:license-check (153 packages loaded, 6745 targets configured)

Analyzing: target //:license-check (154 packages loaded, 9218 targets configured)

Analyzing: target //:license-check (156 packages loaded, 9238 targets configured)

Analyzing: target //:license-check (165 packages loaded, 9284 targets configured)

Analyzing: target //:license-check (165 packages loaded, 9284 targets configured)

Analyzing: target //:license-check (165 packages loaded, 9284 targets configured)

Analyzing: target //:license-check (169 packages loaded, 11296 targets configured)

INFO: Analyzed target //:license-check (170 packages loaded, 11422 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions, 1 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 27.726s, Critical Path: 2.82s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-07-10T04:58:12Z

The created documentation from the pull request is available at: docu-html

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

ryan-steel · 2026-07-20T12:51:38Z

    tags = ["QM"],
-    visibility = ["//score/time_daemon:__subpackages__"],
+    visibility = [
+        "//score/tests/test_scenarios/cpp:__pkg__",


Is this needed? //score/tests/test_scenarios/cpp doesn't exist

Good catch — this visibility entry is needed for the MIT test in part 3 (which links against shm_ptp_engine directly). I'll remove it from this PR and add it in PR3 instead where the package actually exists.

lavrovvalera · 2026-07-29T09:02:21Z

+     visibility = ["//visibility:public"],
+-    deps = ["@score_baselibs//score/json:json_parser"],
+    deps = [
+        "@score_baselibs//score/json:json",


if you are missing this dependency, could you add it to your target to avoid the patch?
or, if you think, the proper place to the dependency is on baselibs side, please, create a ticket towards them and put it here to keep track, when we could drop the patch

The missing json dependency was a bug in score_test_scenarios upstream. It's fixed in v0.4.1, so the patch is no longer needed. Upgraded to v0.4.1 and removed the patch file and the entire score/tests/patches/ directory.

lavrovvalera · 2026-07-29T09:12:28Z

+from testing_utils import LogContainer, ScenarioResult
+
+
+class TestControlFlowPtpDivider(TimeDaemonCitScenario):


I would believe that one and many others (all?) is not the Integration tests but SW Componenet ones.
it doesn't mean, we don't need them, but they are just on differnt level and should be put to differnet folder not to confuse

Agreed. These tests verify interactions between internal Machines within TimeDaemon (intra-process), not cross-component communication — they are SW Component Tests. Renamed the directory integration_tests/ → component_tests/ to reflect the correct level and avoid confusion. All Bazel targets and references updated accordingly.

lavrovvalera · 2026-07-29T09:15:29Z

we don't need it anymore.

Ok, removed.

lavrovvalera · 2026-07-29T12:29:25Z

+
+## Component Integration Test framework
+
+bazel_dep(name = "score_test_scenarios", version = "0.3.0", dev_dependency = True)


Why did you fix the version to the 0.3.0?
I think in the 0.4.1 (?) the issue with json is solved, you will then need no patch any more

You're right. Upgraded to v0.4.1 (fec712d4) — the json dependency issue is fixed upstream so the patch is no longer needed either.

lavrovvalera · 2026-07-29T12:32:35Z

+
+bazel_dep(name = "score_test_scenarios", version = "0.3.0", dev_dependency = True)
+git_override(
+    module_name = "score_test_scenarios",


At the end I would have some doubts about the framework.

the tests which I see here, they do not verify the interaction between differnet sw components, but rather, how the subcompoenents in oecomponent interating between each other.
so, it is the SW Component test, which could be (and even is) implemented by the unit tests (gtests)
cross check for hte test duplication.

for the real integration tests (TimeSlave <-> TimeDameon <-> CustomerApp) I would propose to use score_itf framework which provides the possibility to execute tests on host and on the target platfrom

Understood. The tests in this PR are intentionally SW Component Test level — they verify interactions between internal Machines (VerificationMachine, ControlFlowDivider, IPCMachine, etc.) using in-process stubs, not cross-process IPC. The full plan is three layers:

PR1 (this PR): TimeDaemon component tests — intra-process, score_test_scenarios
PR2: TimeSlave component tests — same level, same framework
PR3: TimeSlave ↔ TimeDaemon module integration test — cross-process, will use score_itf

Cross-check with existing gtests is a good point — will review for duplication before PR3.

lavrovvalera · 2026-07-29T12:33:28Z

+psutil
+pytest-metadata
+pytest-env
+testing-utils @ git+https://github.com/eclipse-score/testing_tools.git@v0.3.0


it would be better to use the githash, not the tag to make the build reproducable

Done. Replaced @v0.3.0 with the pinned commit hash a2f9cded3deb636f5dc800bf7a47131487119721.

lavrovvalera · 2026-07-29T12:35:15Z

+    catch (const std::exception& ex)
+    {
+        std::cerr << ex.what() << std::endl;
+        return 101;


what 101 means here?
is it handled anywhere?

101 is reserved for framework-level crashes — an unhandled C++ exception during scenario runner setup, distinct from test logic results (0 = all pass, 1 = test failure). Added static constexpr int kFrameworkError = 101 to make the intent explicit. The Python side treats any non-zero exit as a setup/framework error.

lavrovvalera · 2026-07-29T12:35:51Z

+            print("Building C++ test scenarios executable...")
+            bazel_tools = BazelTools(option_prefix="cpp", build_timeout=build_timeout)
+            cpp_target_name = session.config.getoption("--cpp-target-name")
+            bazel_tools.build(cpp_target_name, "--config=time-x86_64-linux")


shall we make the bazel config paramterized? now the linux config is hardcoded

Done. Extracted to a --bazel-config pytest CLI option with default time-x86_64-linux. Can be overridden at invocation, e.g. pytest --build-scenarios --bazel-config=time-arm64-qnx.

lavrovvalera · 2026-07-29T12:36:24Z

+        "src/**/*.cpp",
+        "src/**/*.hpp",
+    ]),
+    copts = ["-g"],


do we really need it always?
shall it be controlled from bazel cli?

Removed. Debug symbols can be enabled at the Bazel CLI level with --copt=-g or --compilation_mode=dbg when needed.

lavrovvalera · 2026-07-29T12:37:24Z

+)
+use_repo(pip, "pip_time_daemon_venv")
+
+bazel_dep(name = "rules_cc", version = "0.2.17", dev_dependency = True)


Do we need it?
it wasn't there and assumption, it will come form the project

rules_cc is needed explicitly here because @score_test_scenarios//test_scenarios_cpp loads @rules_cc//cc:cc_library.bzl directly. Since score_test_scenarios is a new dev dependency not present on main, rules_cc must also be declared. Without it the build fails when resolving the module graph.

feat: add TimeDaemon CIT with pip hub infrastructure

46128a4

github-project-automation Bot added this to TIM - Time FT Jul 9, 2026

github-project-automation Bot moved this to In Progress in TIM - Time FT Jul 9, 2026

gordon9901 had a problem deploying to workflow-approval July 9, 2026 08:51 — with GitHub Actions Error

Merge branch 'main' into ecarx_time_daemon_cit

12f0547

gordon9901 had a problem deploying to workflow-approval July 9, 2026 08:52 — with GitHub Actions Error

Update Bazel lockfile

d54cd16

gordon9901 had a problem deploying to workflow-approval July 10, 2026 04:41 — with GitHub Actions Error

feat: add TimeDaemon CIT with pip hub infrastructure

0ea20ba

gordon9901 had a problem deploying to workflow-approval July 10, 2026 04:52 — with GitHub Actions Error

style: apply clang-format to test scenario sources

53d6412

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

gordon9901 had a problem deploying to workflow-approval July 10, 2026 05:56 — with GitHub Actions Error

gordon9901 requested review from BjoernAtBosch and lavrovvalera July 10, 2026 06:04

ryan-steel reviewed Jul 20, 2026

View reviewed changes

drop premature MIT visibility from shm_ptp_engine

26013e6

gordon9901 had a problem deploying to workflow-approval July 22, 2026 10:27 — with GitHub Actions Error

lavrovvalera suggested changes Jul 29, 2026

View reviewed changes

fix: address PR review comments on TimeDaemon CIT

9b39e35

gordon9901 had a problem deploying to workflow-approval July 30, 2026 10:10 — with GitHub Actions Error

update lock file

4939fff

gordon9901 requested a deployment to workflow-approval July 30, 2026 10:18 — with GitHub Actions Waiting

gordon9901 requested review from lavrovvalera and ryan-steel July 30, 2026 10:25

anmittag assigned gordon9901 Jul 31, 2026

		from testing_utils import LogContainer, ScenarioResult


		class TestControlFlowPtpDivider(TimeDaemonCitScenario):


		## Component Integration Test framework

		bazel_dep(name = "score_test_scenarios", version = "0.3.0", dev_dependency = True)

Uh oh!

Conversation

gordon9901 commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gordon9901 commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading