chore: update Bazel version to 8.6.0 and adjust module dependencies - #129
Conversation
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
| module( |
There was a problem hiding this comment.
Why you removed version? Each module should have version.
There was a problem hiding this comment.
no, modules should not have a version. a version is defined by releasing / by bazel registry.
There was a problem hiding this comment.
No, only in root module you may omit the version according to bazel documentation:
https://bazel.build/rules/lib/globals/module#module
version string; default is ''
The version of the module. Can be omitted only if this module is the root module (as in, if it's not going to be depended on by another module). The version must be in a relaxed SemVer format; see the documentation for more details.
There was a problem hiding this comment.
Please revert changes for removing version
There was a problem hiding this comment.
See the MODULE.bazel in the docs-as-code repo root and the score_docs_as_code MODULE.bazel in the registry. The registry overwrites the version according to git tags, so there is no point in writing anything there in the repo.
Removing the version is the right way, otherwise people would think that it matters what is in there.
There was a problem hiding this comment.
You are right. Automation will set versions based on git tag used for creating release.
github-project-automation
Bot
moved this from Backlog
to Done
in TST - Testing Community
4 participants
Recent score modules like docs-as-code are not compatible with bazel 8.5, so this PR upgrade to 8.6.
Background: trying to add itf as a downstream test repo for docs-as-code via eclipse-score/docs-as-code#680