Add module inspection report aggregator with completeness check - #682
Open
FScholPer wants to merge 1 commit into
Open
Add module inspection report aggregator with completeness check#682FScholPer wants to merge 1 commit into
FScholPer wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
FScholPer
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
August 3, 2026 12:40
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Relates to #611
Adds an aggregator on top of
mod_insp(from #661) that makes inspection completeness machine-checkable, grounded in the process concept (Review and Inspection Concept), which defines inspections over three checklist types:requirements/architecture/implementation.mod_inspis the atomic record (one per inspected work product). To prove that a module's report actually contains every inspection it is expected to have, we need an element that aggregates the records and a check that gates coverage. The existing config-drivengraph_checkscan only assert conditions on a linked need — they cannot express coverage/cardinality — so this adds a small Python@graph_check.metamodel.yaml: newmod_insp_reportneed type (prefix: mod_ispr__):mandatory_options:safety/security/status+expected_inspections(comma-separated subset ofrequirements|architecture|implementation— the checklist categories the module must cover).mandatory_links:belongs_to: mod,contains: mod_insp; optionalevidence.checks/graph_checks.py: newcheck_inspection_report_completeness. For eachmod_insp_report, a declaredexpected_inspectionstype counts as covered only if acontains-linked need is amod_inspwithinspection_state == approvedandstatus == valid. Missing types produce a warning, e.g.:requirements.rst:tool_req__docs_inspection_report_need.rst/options/test_options_inspection_report.rst(valid report + invalidexpected_inspections),rst/graph/test_inspection_report.rst(incomplete → warns, complete → clean), and unit tests intest_graph_checks.py.Design note (open for review): the completeness rule is intentionally the declared expected set (
expected_inspections) vs. the contained approved records — deterministic and testable. Auto-deriving the expected set from the module's own work products (itscomp_req/comp_arc/… needs) is a possible level-2 follow-up.🚨 Impact Analysis
✅ Checklist
Frank Scholter Peres frank.scholter_peres@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information