Skip to content

feat: external_needs attribute - #672

Merged
AlexanderLanin merged 2 commits into
eclipse-score:mainfrom
etas-contrib:external-needs-attr
Aug 3, 2026
Merged

feat: external_needs attribute#672
AlexanderLanin merged 2 commits into
eclipse-score:mainfrom
etas-contrib:external-needs-attr

Conversation

@a-zw

@a-zw a-zw commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

📌 Description

Add "external_needs" attribute to "docs" Bazel rule.

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 798e85cd-7eda-4020-8e4e-cb1ed2821860
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 6.381s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@a-zw
a-zw force-pushed the external-needs-attr branch 5 times, most recently from ef2a9ff to 129d2a4 Compare July 29, 2026 08:20
@a-zw
a-zw force-pushed the external-needs-attr branch from 129d2a4 to 3271bf4 Compare July 31, 2026 15:47
@a-zw
a-zw marked this pull request as ready for review July 31, 2026 15:47
Comment thread docs/how-to/other_modules.rst Outdated
Comment thread docs/reference/bazel_macros.rst Outdated
Comment on lines +79 to +83
- ``external_needs`` (list of bazel labels)
External ``:needs_json_file`` targets from other modules/repositories
for referencing their needs.
Users must specify ``:needs_json_file`` explicitly (not ``:needs_json``).
Works the same during ``:docs`` and ``:docs_combo``.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that I see this here... let's discuss how to merge that with #677 and the needs-json PR I cannot find at the moment. Since docs_bundle now exposes sourcecode links and needs_json as well. Seems like its a API mess.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think #677 is related to this PR as it is about source links. Different topic.

The only other PR, I can see is #663 from me. It is draft and simply obsolete with this one.

@AlexanderLanin
AlexanderLanin merged commit 115ea3d into eclipse-score:main Aug 3, 2026
14 checks passed
@AlexanderLanin
AlexanderLanin deleted the external-needs-attr branch August 3, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants