Replace ResultBlank for Result<void> - #824
Open
limdor wants to merge 1 commit into
Open
Conversation
ResultBlank is deprecated
limdor
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11 and
hoe-jo
as code owners
August 3, 2026 14:20
limdor
enabled auto-merge
August 3, 2026 14:27
| } | ||
|
|
||
| score::ResultBlank BidirectionalTransport::Setup() | ||
| score::Result<void> BidirectionalTransport::Setup() |
| } | ||
|
|
||
| score::ResultBlank BidirectionalTransport::SetupSendSocket(score::cpp::stop_token stop_token) | ||
| score::Result<void> BidirectionalTransport::SetupSendSocket(score::cpp::stop_token stop_token) |
| } | ||
|
|
||
| score::ResultBlank BidirectionalTransport::SendAck(const std::uint32_t sequence) | ||
| score::Result<void> BidirectionalTransport::SendAck(const std::uint32_t sequence) |
| } | ||
|
|
||
| score::ResultBlank MessageFramer::SendMessage(std::int32_t socket_fd, const TransportMessage& message) | ||
| score::Result<void> MessageFramer::SendMessage(std::int32_t socket_fd, const TransportMessage& message) |
| } | ||
|
|
||
| score::ResultBlank PendingRequestTracker::WaitForAck(std::uint32_t sequence, | ||
| score::Result<void> PendingRequestTracker::WaitForAck(std::uint32_t sequence, |
| } | ||
|
|
||
| score::ResultBlank SampleHyperVisorTransport::Setup() | ||
| score::Result<void> SampleHyperVisorTransport::Setup() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResultBlank is deprecated