Skip to content

check styling -do not merge - #822

Draft
pawelrutkaq wants to merge 1 commit into
eclipse-score:mainfrom
qorix-group:pawelrutkaq_test_naming
Draft

check styling -do not merge#822
pawelrutkaq wants to merge 1 commit into
eclipse-score:mainfrom
qorix-group:pawelrutkaq_test_naming

Conversation

@pawelrutkaq

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to be a styling-focused change in the COM proxy method implementation, adjusting a local variable name inside queue-slot selection logic.

Changes:

  • Renamed a local boolean in DetermineNextAvailableQueueSlot from all_inactive to all_inactive_.
  • Updated the corresponding conditional to use the renamed variable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +87 to +90
bool all_inactive_ = std::none_of(in_arg_ptr_flags[i].begin(), in_arg_ptr_flags[i].end(), [](bool active) {
return active;
});
if (all_inactive && (!return_type_ptr_flags[i]))
if (all_inactive_ && (!return_type_ptr_flags[i]))
@pawelrutkaq

pawelrutkaq commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author
Checks: >
  -*,
  readability-identifier-naming

CheckOptions:
  - key: readability-identifier-naming.LocalVariableCase
    value: lower_case

  - key: readability-identifier-naming.LocalVariablePrefix
    value: ""

  - key: readability-identifier-naming.LocalVariableSuffix
    value: ""

  - key: readability-identifier-naming.LocalVariableIgnoredRegexp
    value: "^_$"

@4og @LittleHuba @FScholPer ie above config should catch such a naming violation. There is plenty of readability classifiers to describe styling.

@limdor

limdor commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
Checks: >
  -*,
  readability-identifier-naming

CheckOptions:
  - key: readability-identifier-naming.LocalVariableCase
    value: lower_case

  - key: readability-identifier-naming.LocalVariablePrefix
    value: ""

  - key: readability-identifier-naming.LocalVariableSuffix
    value: ""

  - key: readability-identifier-naming.LocalVariableIgnoredRegexp
    value: "^_$"

@4og @LittleHuba @FScholPer ie above config should catch such a naming violation. There is plenty of readability classifiers to describe styling.

@pawelrutkaq what are you trying to achieve here? We are aware that it can be checked like that but it would require a lot of changes including breaking API and it was postponed for the moment.
#392 (comment)

@limdor
limdor marked this pull request as draft August 3, 2026 10:04
@pawelrutkaq

pawelrutkaq commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

This is just the thing that we discussed at FT sync meeting today (a need for a common code style in score) PR to be closed probably in max few day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants