check styling -do not merge - #822
Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears to be a styling-focused change in the COM proxy method implementation, adjusting a local variable name inside queue-slot selection logic.
Changes:
- Renamed a local boolean in
DetermineNextAvailableQueueSlotfromall_inactivetoall_inactive_. - Updated the corresponding conditional to use the renamed variable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| bool all_inactive_ = std::none_of(in_arg_ptr_flags[i].begin(), in_arg_ptr_flags[i].end(), [](bool active) { | ||
| return active; | ||
| }); | ||
| if (all_inactive && (!return_type_ptr_flags[i])) | ||
| if (all_inactive_ && (!return_type_ptr_flags[i])) |
@4og @LittleHuba @FScholPer ie above config should catch such a naming violation. There is plenty of readability classifiers to describe styling. |
@pawelrutkaq what are you trying to achieve here? We are aware that it can be checked like that but it would require a lot of changes including breaking API and it was postponed for the moment. |
|
This is just the thing that we discussed at FT sync meeting today (a need for a common code style in score) PR to be closed probably in max few day. |
No description provided.