Skip to content

fix(core): move the Spring beans under modules/ into the scan roots #6639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delchev merged 1 commit into from
Aug 9, 2026
Merged

fix(core): move the Spring beans under modules/ into the scan roots #6639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...dialects/hana/HanaConnectionEnhancer.java → ...urces/manager/HanaConnectionEnhancer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*
* SPDX-FileCopyrightText: Eclipse Dirigible contributors SPDX-License-Identifier: EPL-2.0
*/
package org.eclipse.dirigible.database.sql.dialects.hana;
package org.eclipse.dirigible.components.data.sources.manager;

import org.eclipse.dirigible.components.api.security.UserFacade;
import org.eclipse.dirigible.components.database.ConnectionEnhancer;
Expand Down
2 changes: 1 addition & 1 deletion ...alects/hana/HanaDatabaseConfigurator.java → ...ces/manager/HanaDatabaseConfigurator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*
* SPDX-FileCopyrightText: Eclipse Dirigible contributors SPDX-License-Identifier: EPL-2.0
*/
package org.eclipse.dirigible.database.sql.dialects.hana;
package org.eclipse.dirigible.components.data.sources.manager;

import com.zaxxer.hikari.HikariConfig;
import org.eclipse.dirigible.components.database.DatabaseConfigurator;
Expand Down
11 changes: 10 additions & 1 deletion components/ide/ide-logs/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,16 @@
<groupId>org.eclipse.dirigible</groupId>
<artifactId>dirigible-components-core-base</artifactId>
</dependency>


<!-- Modules -->
<dependency>
<groupId>org.eclipse.dirigible</groupId>
<!-- ConsoleWebsocketHandler, which the console socket serves and the logging appender
feeds. The appender itself stays in that module: logback configuration names it by
fully qualified class name, downstream configurations included. -->
<artifactId>dirigible-commons-resources</artifactId>
</dependency>

<!-- Test -->
<dependency>
<groupId>org.eclipse.dirigible</groupId>
Expand Down
3 changes: 2 additions & 1 deletion ...mmons/logging/ConsoleWebsocketConfig.java → ...logs/endpoint/ConsoleWebsocketConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
*
* SPDX-FileCopyrightText: Eclipse Dirigible contributors SPDX-License-Identifier: EPL-2.0
*/
package org.eclipse.dirigible.commons.logging;
package org.eclipse.dirigible.components.ide.logs.endpoint;

import org.eclipse.dirigible.commons.logging.ConsoleWebsocketHandler;
import org.eclipse.dirigible.components.base.endpoint.BaseEndpoint;
import org.springframework.context.annotation.Configuration;
import org.springframework.web.socket.WebSocketHandler;
Expand Down
6 changes: 4 additions & 2 deletions ...re/src/main/java/org/eclipse/dirigible/graalium/core/modules/DirigibleSourceProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import org.eclipse.dirigible.repository.api.IResource;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.stereotype.Component;

import java.io.File;
import java.io.IOException;
Expand All @@ -29,8 +28,11 @@

/**
* The Class DirigibleSourceProvider.
*
* <p>
* Deliberately not a Spring bean: every consumer constructs it directly, so the stereotype it used
* to carry only suggested an injection point that never existed.
*/
@Component
@CalledFromJS
public class DirigibleSourceProvider implements JavascriptSourceProvider {

Expand Down
Loading