fix(monitoring): declare the bpmn-visualization webjar the Processes page loads - #6637
Merged
Merged
Conversation
…page loads The Monitoring shell's Processes page loads /webjars/bpmn-visualization/dist/bpmn-visualization.min.js at runtime to render the live BPMN diagram, but resources-monitoring declared no dependencies at all: the webjar reached the classpath only through ui-perspective-processes - that is, through the Web IDE, the one thing this shell is built to work without. So the single assembly the module is designed for is exactly the one where the diagram silently fails: the script 404s, loadLibrary() rejects, and the pane stays empty. Nothing in the build catches it, because the dependency is real in the full build/application and only missing from a curated distribution. Declare it where it is loaded. perspective-processes keeps its own declaration (it loads the same URL from bpm-process-viewer.html) and Maven de-duplicates: the assembly's dependency tree still resolves bpmn-visualization exactly once, at 0.47.0, with no version-conflict warnings - so the full distribution is unchanged and only a curated one gains anything. This matches application-core, which declares the webjars its own pages load rather than relying on a sibling to bring them. The comment on the dependency is deliberate: nothing in this module imports the webjar from Java, so it reads as removable unless the reason is written down. Closes #6634 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6634.
resources-monitoring's Processes page loads/webjars/bpmn-visualization/dist/bpmn-visualization.min.jsat runtime(
js/services/processDiagram.js:13) to render the live BPMN diagram, but the module declared nodependencies at all. The webjar reached the classpath only through
ui-perspective-processes— thatis, through the Web IDE, which is the one thing this shell is explicitly built to work without.
So the single assembly the module is designed for is exactly the one where the diagram silently fails:
the
<script>404s,loadLibrary()rejects, and the pane stays empty. Nothing in the build catchesit, because the dependency is real in the full
build/applicationand only missing from a curateddistribution.
The change
One dependency, on the module whose page loads it —
org.webjars.npm:bpmn-visualizationat theexisting
${bpmn-visualization.version}. This matches howapplication-corealready works: itdeclares the webjars its own pages load (
alpinejs,codbex__harmonia,lucide,pinecone-router,i18next,fontsource__open-sans) rather than relying on a sibling to bring them.perspective-processeskeeps its own declaration — it loads the same URL frombpm-process-viewer.html.Verification
dependency:treeonresources-monitoringnow resolvesbpmn-visualization:0.47.0directly, withits transitives (
typed-mxgraph,es-toolkit,fast-xml-parser,mxgraph).dependency:treeonbuild/applicationstill resolves it exactly once, at 0.47.0, with zeroversion-conflict warnings — so the full distribution is byte-for-byte unaffected and only a curated
assembly gains anything.
.../0.47.0/dist/bpmn-visualization.min.js, servedversion-lessly by webjars-locator — the same URL
perspective-processeshas been loading).mvn clean installgreen on the module.Notes
The dependency carries a comment. Nothing in this module imports the webjar from Java, so it reads as
an unused dependency and would be a natural thing for someone to "clean up" — the comment records why
it is there.
Scope check while I was in here:
resources-monitoringloads five webjar URLs. The other four(
alpinejs,codbex__harmonia,lucide,pinecone-router) are covered byapplication-core, whichany assembly containing the shared shell runtime must include anyway — so
bpmn-visualizationwas theonly orphan. The sibling shells (
resources-admin,-application,-personal,-partner) declare nodependencies for the same reason and are fine as they are.
🤖 Generated with Claude Code