chore(api): remove the empty api-junit module - #6622
Open
delchev wants to merge 1 commit into
Open
Conversation
The module contains only a pom.xml (both dependencies test-scoped), has never had sources in the components era, sits in no group aggregator, and is referenced by nothing - every release publishes it to Maven Central as an empty jar. The actual JUnit capability is unaffected and ships elsewhere: - the JS/TS sdk/junit module in api-modules-javascript, which also carries the runtime junit-jupiter dependency - TestResultsService/TestResultsEndpoint in ide-junit-results - the self-contained client-Java sdk.junit.Assert in api-modules-java Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
components/api/api-junit— a pom-only module with nosrc/, whose two dependencies are both test-scoped, so it builds an empty jar by construction. It sits in nogroup-*aggregator, nothing references its artifactId anywhere in the repo, and it is absent from the fat jar'sBOOT-INF/lib. Its only observable effect is that every release publishes an emptydirigible-components-api-junitartifact to Maven Central.Two deletions:
components/api/api-junit/directory<module>entry incomponents/pom.xmlWhy removal rather than aggregation
The JUnit capability is unaffected — it ships through three other modules:
api-modules-javascript— the JS/TSsdk/junitmodule (test,assertEquals, …) wrappingorg.junit.jupiter.api.Assertions; this pom also carries the compile-scopedjunit-jupiterdependency that puts the assertion classes intoBOOT-INF/libide-junit-results—TestResultsService/TestResultsEndpoint, the result-tracking side the JS module callsapi-modules-java— the self-contained client-Javasdk.junit.Assert(no dependency on api-junit)The module's git history in the components era is only release version bumps — it was scaffolded during the 6.x→7.0 re-architecture and never populated.
Verification
api-junitreturns zero references outside the removed modulemvn -T 1C clean install -P quick-buildgreen after the removal🤖 Generated with Claude Code