Skip to content

chore: drop the chart.js webjar and sweep the stale AngularJS references (#6590) - #6621

Merged
delchev merged 3 commits into
masterfrom
chore/drop-chartjs-and-angular-refs
Aug 8, 2026
Merged

chore: drop the chart.js webjar and sweep the stale AngularJS references (#6590)#6621
delchev merged 3 commits into
masterfrom
chore/drop-chartjs-and-angular-refs

Conversation

@delchev

@delchev delchev commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Closes #6590. Part of the umbrella #6591 — the final cleanup of the wave.

Stacked on #6620 (refactor/retire-dashboard-shell), because chart.js only becomes
consumer-less once the AngularJS Dashboard shell is gone. Retarget to master after #6620 merges.

  1. chart.js webjar dropped — its last consumer was resources-dashboard/.../dashboard.html;
    Harmonia reports render through Harmonia's own native x-h-chart-* SVG charts. Removed: the
    dependency in resources-resources (leaving the module its images/unicons), the
    <chart.js.version> property in the root pom, the README attribution and the library lists in
    CLAUDE_FEATURES.md. grep -rn "webjars/chart" components modules tests build is empty
    (resources-dev-tools' unrelated *Chart.js files left alone, as the issue asks).
  2. Docs sweep for claims the removals made false: root CLAUDE.md (the chart.js webjar
    "remains only for the AngularJS dashboard shell"; the widgetSize and full-stack comparisons with
    the removed AngularJS stacks; the application shell described as the counterpart to a shell that no
    longer exists), a status banner on HARMONIA_RUNTIME_PLAN.md marking its parallel-stack framing
    historical rather than rewriting the design record, and the deferred Chart.js item in
    HARMONIA_2_MIGRATION.md.
  3. IntentSettings comments — item 2 of the issue is already done: the recipe comments were
    corrected when the AngularJS templates were removed, and no angular template id remains in
    engine-intent. No change needed.

Verification

Final survivors grep — ui-angular | form-builder-angularjs | template-application-angular over
components modules tests build (*.java,*.js,*.json,*.gen*,*.template) — empty.
mvn -T 1C clean package -P quick-build green; the built instance starts and every shell loads.

🤖 Generated with Claude Code

delchev and others added 3 commits August 8, 2026 09:16
…s to resources-application (#6589)

The twelve platform-wide extension points application-{perspectives, views,
menus, settings, locales, shells, themes, tile, windows, subviews, reports} and
dashboard-widgets were declared by the AngularJS Dashboard shell, but their
consumers sit far outside it - the Harmonia shells, the Harmonia UI template's
perspective extension, Inbox, Documents, platform-core, the settings and
translation views.

They move next to application-projections in resources-application, which is
the shell that actually aggregates them, so the AngularJS module can be removed
in the following commit. Lookup is by extension-point NAME
(ExtensionsFacade.getExtensions), so nothing about resolution changes; only the
declaring location does.

Part of #6591.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
resources-dashboard hosted the AngularJS-generated application perspectives at
/services/web/dashboard/. Those templates were removed in #6588, so the shell
has no consumer left: the generated apps are Harmonia SPAs served per project,
and the Harmonia application shell in resources-application is the launchpad.

Removed with it: the Dashboard and Reports AngularJS perspectives, the shared
EntityService/ProcessTasks AngularJS services (their only consumers were the
generated AngularJS views), the module's i18n and images, and the three Maven
wirings. The extension-point declarations moved to resources-application in the
preceding commit.

The Harmonia application shell keeps its id (applicationShell), its label
(Applications) and its /services/web/application/ URL - renaming it was
considered and dropped.

Migration: already-generated AngularJS applications stop working at runtime,
since their views load shell assets from /services/web/dashboard/. Regenerating
with the Harmonia template is required, not optional.

Part of #6591.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ces (#6590)

The chart.js webjar's last consumer was the AngularJS Dashboard shell removed in
#6589 - Harmonia reports render through Harmonia's own native x-h-chart-* SVG
charts - so the dependency in resources-resources and the <chart.js.version>
property in the root pom are dropped, together with the third-party attribution
in README.md and the library lists in CLAUDE_FEATURES.md.

Docs sweep for claims the removals made false: CLAUDE.md (the chart.js webjar
"remains only for the AngularJS dashboard shell", the widgetSize/full-stack
comparisons with the AngularJS stacks, and the application shell described as
the counterpart to a shell that no longer exists), a status banner on
HARMONIA_RUNTIME_PLAN.md marking its parallel-stack framing historical, and the
deferred Chart.js item in HARMONIA_2_MIGRATION.md.

The stale IntentSettings comments the issue lists were already corrected when
the AngularJS templates were removed; the survivors grep
(ui-angular | form-builder-angularjs | template-application-angular over
components, modules, tests and build) is empty.

Closes #6591 once the migration issues land.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@delchev
delchev force-pushed the refactor/retire-dashboard-shell branch from 5d1dac7 to 0364a4a Compare August 8, 2026 06:16
@delchev
delchev force-pushed the chore/drop-chartjs-and-angular-refs branch from 090ca70 to f66ce82 Compare August 8, 2026 06:17
Base automatically changed from refactor/retire-dashboard-shell to master August 8, 2026 06:21
@delchev
delchev merged commit 271cb8a into master Aug 8, 2026
6 of 7 checks passed
@delchev
delchev deleted the chore/drop-chartjs-and-angular-refs branch August 8, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cleanup: drop the chart.js webjar and the stale AngularJS template references

1 participant