Skip to content

adapter: allow optional valueId in ValueReferencePair for JSON and XML #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-heppner merged 6 commits into from
Jun 29, 2026
Merged

adapter: allow optional valueId in ValueReferencePair for JSON and XML #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
114f42f
adapter: Allow optional contentType in Blob and File
paul-gerber-svg Jun 15, 2026
65f2d9c
fix(adapter): allow optional 'valueId' in 'ValueReferencePair' for JS…
paul-gerber-svg Jun 18, 2026
0330a7b
Fix type hinting for valueId
paul-gerber-svg Jun 18, 2026
1bc439b
fix whitespace issues
paul-gerber-svg Jun 18, 2026
c4bb9d9
fix whitespace issues again
paul-gerber-svg Jun 18, 2026
9e7447c
Merge branch 'develop' into fix-optional-value-id
s-heppner Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/basyx/aas/adapter/json/json_deserialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,8 @@ def _construct_value_list(cls, dct: Dict[str, object]) -> model.ValueList:
def _construct_value_reference_pair(cls, dct: Dict[str, object],
object_class=model.ValueReferencePair) -> model.ValueReferencePair:
return object_class(value=_get_ts(dct, 'value', str),
value_id=cls._construct_reference(_get_ts(dct, 'valueId', dict)))
value_id=cls._construct_reference(_get_ts(dct, 'valueId', dict))
if 'valueId' in dct else None)

# #############################################################################
# Direct Constructor Methods (for classes with `modelType`) starting from here
Expand Down Expand Up @@ -705,6 +706,7 @@ def _construct_blob(cls, dct: Dict[str, object], object_class=model.Blob) -> mod

@classmethod
def _construct_file(cls, dct: Dict[str, object], object_class=model.File) -> model.File:
content_type = _get_ts(dct, "contentType", str) if 'contentType' in dct else None
ret = object_class(id_short=None,
value=None,
content_type=_get_ts(dct, "contentType", str) if 'contentType' in dct else None)
Expand Down
4 changes: 3 additions & 1 deletion sdk/basyx/aas/adapter/xml/xml_deserialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,8 +1063,10 @@ def construct_submodel(cls, element: etree._Element, object_class=model.Submodel
@classmethod
def construct_value_reference_pair(cls, element: etree._Element, object_class=model.ValueReferencePair,
**_kwargs: Any) -> model.ValueReferencePair:
value_id_element = element.find(NS_AAS + "valueId")
value_id = cls.construct_reference(value_id_element, **_kwargs) if value_id_element is not None else None
return object_class(_child_text_mandatory(element, NS_AAS + "value"),
_child_construct_mandatory(element, NS_AAS + "valueId", cls.construct_reference))
value_id)

@classmethod
def construct_value_list(cls, element: etree._Element, **_kwargs: Any) -> model.ValueList:
Expand Down
Loading