Add Transaction.setGeneratedPropertiesEnabled(boolean)#3799
Merged
Conversation
Adds transaction-level control over whether Ebean auto-generates values for @WhenCreated, @WhenModified, @Whocreated and @WhoModified properties. Motivation Backup/restore scenarios need to preserve the original audit timestamps and user values when re-inserting exported data. Without this, every save overwrites those fields with the current time/user. Usage try (Transaction txn = DB.beginTransaction()) { txn.setGeneratedPropertiesEnabled(false); bean.setWhenCreated(originalTimestamp); bean.setWhenModified(originalTimestamp); DB.save(bean); txn.commit(); } Behaviour - Disabled (false): generated property values are only written if the property currently has a null value. Any non-null value set on the bean is preserved. - @Version is unaffected: the version property always auto-increments regardless of this setting, preserving optimistic locking integrity. - Default is true: all existing behaviour is unchanged. Files changed - Transaction — new setGeneratedPropertiesEnabled(boolean) with javadoc - SpiTransaction — new isGeneratedPropertiesEnabled() - SpiTransactionProxy — delegates both methods - JdbcTransaction — field + implementation (default true) - NoTransaction, ImplicitReadOnlyTransaction — no-op setter, true getter - PersistRequestBean — onInsertGeneratedProperties, onUpdateGeneratedProperties, onFailedUpdateUndoGeneratedProperties all gate on isGeneratedPropertiesEnabled() - TestGeneratedProperties — 3 new tests covering insert-preserves, insert-null-still-filled, and update-preserves Supersedes PR #2943 — same feature, renamed from setOverwriteGeneratedProperties to setGeneratedPropertiesEnabled for a clearer, positive-sense API.
Member
Author
|
This PR replaces #2943 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds transaction-level control over whether Ebean auto-generates values for
@WhenCreated,@WhenModified,@WhoCreatedand@WhoModifiedproperties.Motivation
Backup/restore scenarios need to preserve the original audit timestamps and user values when re-inserting exported data. Without this, every save overwrites those fields with the current time/user.
Usage
Behaviour
@Versionis unaffected: the version property always auto-increments regardless of this setting, preserving optimistic locking integrity.Files changed
Supersedes
PR #2943 — same feature, renamed from setOverwriteGeneratedProperties to setGeneratedPropertiesEnabled for a clearer, positive-sense API.