-
-
Notifications
You must be signed in to change notification settings - Fork 265
NEW: Ebean can generate HtmlMetricReports #2954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
ebean-api/src/main/java/io/ebean/meta/MetricReportGenerator.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package io.ebean.meta; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.OutputStream; | ||
| import java.util.List; | ||
|
|
||
| /** | ||
| * The metric report. most likely a HTML report. | ||
| */ | ||
| public interface MetricReportGenerator { | ||
|
|
||
| /** | ||
| * Writes the report to the outputStream. The stream will not be closed. | ||
| */ | ||
| void writeReport(OutputStream out) throws IOException; | ||
|
|
||
| /** | ||
| * Used to configure the metric. This report dependent. | ||
| * Returns a string result, that should be sent back to the web application | ||
| */ | ||
| String configure(List<MetricReportValue> values); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This might be a bit hackish, but it allows me to keep the Spring rest controller very simple |
||
| } | ||
39 changes: 39 additions & 0 deletions
39
ebean-api/src/main/java/io/ebean/meta/MetricReportValue.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package io.ebean.meta; | ||
|
|
||
| /** | ||
| * A Metric report value used to configure a metric report. | ||
| * This is most likely a REST call from the provided web-application | ||
| */ | ||
| public class MetricReportValue { | ||
| private String name; | ||
| private String value; | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| public void setName(String name) { | ||
| this.name = name; | ||
| } | ||
|
|
||
| public String getValue() { | ||
| return value; | ||
| } | ||
|
|
||
| public void setValue(String value) { | ||
| this.value = value; | ||
| } | ||
|
|
||
| public int intValue() { | ||
| return Integer.valueOf(value); | ||
| } | ||
|
|
||
| public MetricReportValue() { | ||
|
|
||
| } | ||
|
|
||
| public MetricReportValue(String name, Object value) { | ||
| this.name = name; | ||
| this.value = String.valueOf(value); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used outputStream here, because someone might want to generate PDFs