Daily era5 and era5-land#174
Open
MarkMelotto wants to merge 5 commits into
Open
Conversation
Author
|
I think some help with the checks is required 😅 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 98.96% 98.83% -0.13%
==========================================
Files 13 13
Lines 579 602 +23
==========================================
+ Hits 573 595 +22
- Misses 6 7 +1 🚀 New features to boost your workflow:
|
sverhoeven
requested changes
Jul 2, 2026
sverhoeven
left a comment
Member
There was a problem hiding this comment.
We should drop Python 3.9 support as it is end of life since last year. That will solve the py3.9 job. Dropping python 3.9 can be done with:
- drop 3.9 in .github/workflows/test_and_build.yml
- in pyproject.toml set
requires-python = ">=3.10"and remove "Programming Language :: Python :: 3.9" line
I was able to run
# era5 2dvar
uv run era5cli daily --variables total_precipitation --startyear 2000 --months 11
# era5-land
uv run era5cli daily --variables 2m_temperature --startyear 2000 --months 11 | "isort", | ||
| "pytest", | ||
| "pytest-flake8", | ||
| # "pytest-flake8", |
Member
There was a problem hiding this comment.
Do not know why this was disabled. When I run
hatch run lint | grep -v venv
./era5cli/args/periods.py:126:1: W293 blank line contains whitespace
./era5cli/args/periods.py:143:89: E501 line too long (93 > 88 characters)
./era5cli/fetch.py:135:89: E501 line too long (89 > 88 characters)
./era5cli/fetch.py:381:89: E501 line too long (96 > 88 characters)
./tests/test_fetch.py:282:89: E501 line too long (96 > 88 characters)
./tests/test_fetch.py:485:89: E501 line too long (89 > 88 characters)
./tests/test_fetch.py:550:89: E501 line too long (111 > 88 characters)
./tests/test_fetch.py:565:89: E501 line too long (113 > 88 characters)These all look like solvable problems.
| assert args.land | ||
| assert not args.area | ||
|
|
||
| argv = [ |
Member
There was a problem hiding this comment.
It is nicer to have a single thing under test for each test.
Suggested change
| argv = [ | |
| def test_parse_args_daily(): | |
| argv = [ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi era5cli team,
Adressing issue #172: I added functionality to download era5(-land) data to era5cli.
I added some basic tests, please let me know if more are needed!
I have not yet added to the documentation, if you approve of the change I will add documentation and then we can merge!
Mark Melotto