Skip to content

Daily era5 and era5-land#174

Open
MarkMelotto wants to merge 5 commits into
mainfrom
daily-era5-land
Open

Daily era5 and era5-land#174
MarkMelotto wants to merge 5 commits into
mainfrom
daily-era5-land

Conversation

@MarkMelotto

Copy link
Copy Markdown

Hi era5cli team,

Adressing issue #172: I added functionality to download era5(-land) data to era5cli.
I added some basic tests, please let me know if more are needed!

I have not yet added to the documentation, if you approve of the change I will add documentation and then we can merge!

Mark Melotto

@MarkMelotto

Copy link
Copy Markdown
Author

I think some help with the checks is required 😅

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.83%. Comparing base (cfd5076) to head (5a4000a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   98.96%   98.83%   -0.13%     
==========================================
  Files          13       13              
  Lines         579      602      +23     
==========================================
+ Hits          573      595      +22     
- Misses          6        7       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarkMelotto MarkMelotto requested a review from sverhoeven July 1, 2026 09:06

@sverhoeven sverhoeven left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop Python 3.9 support as it is end of life since last year. That will solve the py3.9 job. Dropping python 3.9 can be done with:

  • drop 3.9 in .github/workflows/test_and_build.yml
  • in pyproject.toml set requires-python = ">=3.10" and remove "Programming Language :: Python :: 3.9" line

I was able to run

# era5 2dvar
uv run era5cli daily --variables total_precipitation --startyear 2000 --months 11
# era5-land
uv run era5cli daily --variables 2m_temperature --startyear 2000 --months 11 

Comment thread pyproject.toml
"isort",
"pytest",
"pytest-flake8",
# "pytest-flake8",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not know why this was disabled. When I run

hatch run lint | grep -v venv
./era5cli/args/periods.py:126:1: W293 blank line contains whitespace
./era5cli/args/periods.py:143:89: E501 line too long (93 > 88 characters)
./era5cli/fetch.py:135:89: E501 line too long (89 > 88 characters)
./era5cli/fetch.py:381:89: E501 line too long (96 > 88 characters)
./tests/test_fetch.py:282:89: E501 line too long (96 > 88 characters)
./tests/test_fetch.py:485:89: E501 line too long (89 > 88 characters)
./tests/test_fetch.py:550:89: E501 line too long (111 > 88 characters)
./tests/test_fetch.py:565:89: E501 line too long (113 > 88 characters)

These all look like solvable problems.

Comment thread tests/test_cli.py
assert args.land
assert not args.area

argv = [

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nicer to have a single thing under test for each test.

Suggested change
argv = [
def test_parse_args_daily():
argv = [

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants