feat: add istanbul-lib-coverage to preferred replacements - #1028
feat: add istanbul-lib-coverage to preferred replacements#1028ChrisJr404 wants to merge 1 commit into
Conversation
|
Should we also add other |
dreyfus92
left a comment
There was a problem hiding this comment.
thanks @ChrisJr404 for putting this together, and @AriPerkkio for the quick review.
one thing I was wondering about while reading the docs page: the fork has engines: node >=22 and ships ESM-only, which is a bigger jump than "just swap the import" for some projects. would it be worth a line or two mentioning that, so people on older Node or CJS aren't caught off guard?
@gameroman good call on the other istanbul-* packages, but i'd rather keep this PR scoped to istanbul-lib-coverage since the linked issue covers just this one and it's already approved. would you mind opening a tracking issue for the rest?
| @@ -0,0 +1,31 @@ | |||
| --- | |||
| description: Replace the unmaintained istanbul-lib-coverage package with the maintained @vitest/istanbul-lib-coverage fork | |||
There was a problem hiding this comment.
this should probably be worded similar to the others, "Modern alternatives to ..."
|
|
||
| # Replacements for `istanbul-lib-coverage` | ||
|
|
||
| `istanbul-lib-coverage` is no longer maintained. The Vitest team publishes |
There was a problem hiding this comment.
the context around the vitest fork should be in the vitest section, leaving only the "no longer maintained" message here i think
Adds
istanbul-lib-coverageto the preferred manifest, pointing at the maintained@vitest/istanbul-lib-coveragefork, since the original is no longer maintained.The fork keeps the same API so migrating is mostly just swapping the import, and it ships as ESM with its own types. I added a docs page covering that.
Closes #993