⚡ perf(ui): Optimize layout update loop to prevent redundant change detection - #26
⚡ perf(ui): Optimize layout update loop to prevent redundant change detection#26dynamikdev wants to merge 1 commit into
Conversation
Optimized `update_circle_layout` in `src/ui/systems.rs` to prevent unconditional cloning of `text_font.font` on every frame update. Replaced unconditional mutations to `Transform` and `TextFont` with conditional checks based on `f32::EPSILON` and handle equality. This prevents `DerefMut` triggers, completely avoiding unnecessary Bevy change detection cycles and layout recomputations when values have not meaningfully changed. Co-authored-by: dynamikdev <717692+dynamikdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added conditional assignments in
update_circle_layoutloop fortransform.translation,text_font.font, andtext_font.font_size.🎯 Why: Previously, the loop unconditionally mutated component properties and cloned a Handle. In Bevy, this triggers
DerefMut, falsely flagging the components as "changed" every frame and forcing downstream systems to perform expensive layout/render recomputations.📊 Measured Improvement: We do not have a Bevy system benchmark configured, but statically this eliminates 1 atomic ARC increment (
clone()) and 1 change-detection invalidation per target entity per frame, dropping CPU load meaningfully during idle application states.PR created automatically by Jules for task 4623681990949253160 started by @dynamikdev